Page MenuHomeMiraheze
Create Task
Maniphest T10285

Requesting download from MultiMedia Viewer does not work
Closed, ResolvedPublic
Actions

Description

Then you visit this https://static.miraheze.org/gpcommonswiki/6/60/Commons-logo-black-which.png?download the download is supposed to start automatically. Also viewing from the MultiMedia Viewer (https://gpcommons.miraheze.org/wiki/File:Miraheze_logo.svg#/media/File:Miraheze_logo.svg), when you try to download from the download button, the download is supposed to start automatically, but all these doesn't work.

This doesn't work on any wiki I have tried it from.

I assume it is a bug, wrong configuration, or something that is supposed to be done but not done.

Related Objects

Event Timeline

Excelsis triaged this task as Normal priority.Jan 13 2023, 10:35
Excelsis created this task.
Herald added subscribers: Agent_Isai, Unknown Object (User), Reception123. · View Herald TranscriptJan 13 2023, 10:35
Excelsis added a project: MediaWiki (SRE).Jan 13 2023, 10:36
OrangeStar added a project: Extensions.Jan 14 2023, 16:49
OrangeStar subscribed.

The extension has a section about these situations (https://www.mediawiki.org/wiki/Extension:MultimediaViewer#Configuration). TLDR It requires sending a header at the web server level: "If the requested URL to an image directory contains the download query parameter, the Content-Disposition header must be set to attachment".

However, unless you're trying to support Internet Explorer in 2023, this should really be done by setting the download attribute at the <a> element in the extension's code instead.

Herald added a project: Universal Omega. · View Herald TranscriptJan 14 2023, 16:49
OrangeStar added a comment.Jan 14 2023, 22:39

I've attempted to port the Wikimedia version to Miraheze: https://github.com/miraheze/puppet/pull/3121.

Reviews are very much welcome, I've never used either Varnish or Puppet.

Restricted Repository Identity mentioned this in rPUPCb071f9cfc51f: T10285: Set Content-Disposition header on static.miraheze.org requests….Jan 15 2023, 14:56
OrangeStar claimed this task.Jan 15 2023, 15:00

The PR got merged, should be working once the change is deployed to production

Paladox closed this task as Resolved.Jan 15 2023, 15:06
Excelsis awarded a token.Jan 15 2023, 21:51
Excelsis moved this task from Backlog to Short Term on the MediaWiki (SRE) board.Jan 15 2023, 21:54
Excelsis moved this task from Unsorted to Short Term on the Universal Omega board.