Page MenuHomeMiraheze

Citizen theme navigation button broken for logged in admins of the wiki after MW1.39 update
Closed, ResolvedPublic

Assigned To
Unknown Object (User)
Authored By
Max20091
Jan 22 2023, 06:37
Referenced Files
F2025711: gambar.png
Feb 17 2023, 06:01
F2024626: gambar.png
Feb 16 2023, 07:10
F2024624: gambar.png
Feb 16 2023, 07:10
F2011838: gambar.png
Jan 29 2023, 07:11
F2011836: gambar.png
Jan 29 2023, 07:11
F2011840: gambar.png
Jan 29 2023, 07:11
F2010163: image.png
Jan 22 2023, 06:37
F2010161: image.png
Jan 22 2023, 06:37

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Login account with admin permission

What happens?:

image.png (490×787 px, 69 KB)

What should have happened instead?:
image.png (812×1 px, 167 KB)

Browser information, screenshots and other applicable information:
Microsoft Edge 109

Event Timeline

I tried these things but didn't work:

  • Cleared browser cache
  • Purged pages
  • Edited sidebar

Hi, we are also having this issue on https://nucarnival.miraheze.org.
Customized [[MediaWiki:Sidebar]] is not reflected with citizen skin.
And on my side, this is also happened for all users, including not logged in users.

I would assume this is probably an upstream issue but will let @Universal_Omega first

It seems that there is a conflict between ManageWiki and Citizen that wiped out the whole bar. It affects users with ManageWiki permissions. I'm not entirely sure what caused it though.

I'm not sure if it is conflict with ManageWiki, since on my wiki, even user without ManageWiki permissions also affected.

Here's the content of my Sidebar configuration.

gambar.png (870×600 px, 89 KB)

And both of these screenshots taken while the user is not logged in yet.
As you can see, there are no alert/notice icon on citizen, and no "Switch to old look" on vector-2022

This is the main page using citizen skin (default).

gambar.png (870×600 px, 140 KB)

This is the main page using vector-2022 skin (forced with ?useskin parameter).
gambar.png (870×600 px, 145 KB)

As you can see, citizen skin only the first section of the sidebar is visible, while on vector-2022 all sections are visible.
Note that I hide the first sections ("All menu") for other skins beside citizen with custom CSS.

Of course for logged-in users with ManageWiki permissions, ManageWiki links also missing.
And, it's quite insteresting to know that on your wikis this problem only occurs for users with ManageWiki permissions.

Reception123 assigned this task to Unknown Object (User).Feb 13 2023, 14:58

Hi, I saw that the github issue on StarCitizenTools for this one was marked as closed/completed.
Since I'm still having this issue, I'm wondering is it already fixed there, and we just need to update the skin?
Or it something that should be fixed on Miraheze side?

Not fixed, compatibility errors between ManageWiki and Citizen have been suggested, but nothing confirmed yet apparently.

Unknown Object (User) added a comment.EditedFeb 15 2023, 18:00

I can't see how there would be any compatability issue between the two, and if there is, it is an issue with Citizen likely, since it works with other skins. But again, I don't see how at all that their could be compatability issues with ManageWiki. The only thing it does with the sidebar is use it with a hook to add the ManageWiki links. If it is an incompatibility, then it would be with any other extension that uses the same hook as well.

Citizen does use the same hook as well, which makes me wonder if it is an issue with MediaWiki core itself or something else, I'll see what I can do about it.

Should be fixed upstream now, it is a minor error where the index key wasn't reset after removing the toolbox.

Unknown Object (User) closed this task as Resolved.Feb 16 2023, 01:35

I have now updated the skin.

Hi, I just test it again.
But, while links from all sections have returned, the heading label itself is still missing.
I'm not certainly sure, but it seems only section below the toolbox that has this issue.

Vector - there's "Contents" heading before Characters link:

gambar.png (253×187 px, 5 KB)

Citizen - no heading before Characters link, but "Administration" heading is shown somehow:
gambar.png (288×464 px, 23 KB)

Err, now the "Administration" section heading is gone...

gambar.png (450×952 px, 62 KB)

Unknown Object (User) added a comment.Feb 17 2023, 06:08

This is starting to seem like whack-a-mole with fixes here... but things happen sometimes...

@Alistair3149 ^

Thanks for the quick actions. I'll look into it next week.

Okay I finally locked down the issue, it should be fixed now.

Nice, looks good now.
Thank you for fixing.