Page MenuHomeMiraheze

Navigation sidebar doesn't function
Closed, ResolvedPublic

Description

The sidebar on the left side of the wiki I work on (https://degreesoflewdity.miraheze.org/wiki/Main_Page) doesn't work. When a section is clicked, it instantly closes back up so no one can use it to navigate the wiki.

Event Timeline

BrandonWM triaged this task as Normal priority.Jan 25 2023, 20:12
BrandonWM added a project: MediaWiki.
OrangeStar claimed this task.
OrangeStar subscribed.

This looks like a JS issue. There are 2 click event handlers at the elements in the sidebar, one from the Timeless skin's JS, and another from MediaWiki:Timeless.js. Both call .toggle right after the other one, so that's why you see it open and close so fast. Preventing MediaWiki:Timeless.js from loading fixes this, so remove the one at MediaWiki:Timeless.js to fix this.

So I've been messing with timeless.js for over 24 hours at this point and am beyond frustrated. Removing one of the toggles as suggested does stop the instant open/close issue, but introduces the new issue of clicking the tab doing nothing at all. I'm less inclined to believe this is a js issue since this issue didn't appear until the update to mediawiki 1.3.9 and looking through the timeless skin's js didn't actually net me a toggle to stop things on that end either.

Here is the event handlers at the "Wiki Navigation" sidebar element.

Wiki Navigation events.png (176×966 px, 66 KB)

The first one is the JS included with the skin, the second one is from MediaWiki:Timeless.js, at line 39. Remove all the "click" event handlers for sidebar elements, and you'll not have this issue.

I would like to restate that I have done this already and rolled back the changes more times than I'd care to admit. Whenever I'd delete the "click" event handlers in mediawiki:timeless.js, the sidebar would become useless because clicking would do nothing.

ezgif.com-gif-maker(1).gif (325×600 px, 547 KB)

OrangeStar removed OrangeStar as the assignee of this task.
OrangeStar closed this task as Invalid.EditedJan 27 2023, 14:42

MediaWiki:Timeless.js was being imported twice, once through MediaWiki.Common.js and another as skin-specific JS by MediaWiki. Skin JS files should only have JS specific for that skin, the problem is with the wiki's JS setup.

ezgif.com-gif-maker(2).gif (325×600 px, 1 MB)

Once again, I have to remind you that this problem only popped up after the update to 1.3.9. But I was willing to try it anyway, so I removed the offending bit of code. Lo and behold, it fixed nothing. Even with that removed, the problem remains. I'd also like to ask for someone else to be assigned to this because it feels like we're going nowhere with the one currently on it and it feels like the main point of "This was working before the update" is being missed in order to continue pointing blame at something that, again, was working just fine before the update.

Reception123 assigned this task to Unknown Object (User).Feb 13 2023, 14:58
Unknown Object (User) closed this task as Resolved.Feb 16 2023, 01:54

This should now be fixed.