Page MenuHomeMiraheze
Create Task
Maniphest T1674

CheckUser group bug
Closed, ResolvedPublic
Actions

Description

There appears to be a bug with the "check user" group. Even when the group is unset in LocalWiki.php, something is still defining it in ListGroupRights and userrights management. Apparently this is not just a Miraheze issue because @Void said they have seen it elsewhere. I suspect that this is upstream, but I'm not completely sure.

Event Timeline

• Amanda created this task.Apr 16 2017, 20:07
• Amanda created this object in space S1 Public.
• Amanda created this object with edit policy "All Users".
Herald added subscribers: revi, Southparkfan, ImBoPhil and 2 others. · View Herald TranscriptApr 16 2017, 20:07
• Amanda moved this task from Backlog to Deployed Extension Bugs on the Extensions board.Apr 16 2017, 20:08
• Amanda moved this task from Backlog to Blocked by upstream on the Configuration board.
Void lowered the priority of this task from High to Low.Apr 16 2017, 20:57

Little to no impact on site functionality.

I've been trying to figure out where the group is defined to begin with, but have been met with little luck. Unlike most other 'default' groups, it is not located in DefaultSettings.php, and is not apparent in the extension's files. Most likely Upstream.

• Amanda raised the priority of this task from Low to Normal.Apr 17 2017, 15:55
• Amanda added a project: Upstream.

Most other upstream tasks are normal

Reception123 lowered the priority of this task from Normal to Low.Apr 17 2017, 15:57

The other tasks prevent something to be done, this one is just a small disadvantage that doesn't actually affect anything.

Reception123 added a comment.Apr 17 2017, 15:59

@Amanda If you add an the Upstream it means that you have created an upstream task at https://phabricator.wikimedia.org . Please either do so or remove the task if it is not sure that this is an upstream issue.

• Amanda removed a project: Upstream.Apr 17 2017, 17:07
John closed this task as Invalid.May 12 2017, 16:11
John subscribed.

No longer valid.

Potentially was only a code ordering issue.

AmandaCath reopened this task as Open.Jul 25 2018, 14:39
AmandaCath added a project: Upstream.
AmandaCath edited subscribers, added: AmandaCath; removed: • Amanda.

This is still an issue, even ~6 months later, and therefore is not invalid. I have emailed the MediaWiki mailing list and CC’d staff@ - hopefully someone upstream can figure this out. Adding the upstream tag even though I didn’t file on WMF Phab (yet), since emailing the mailing list still technically counts as reporting/seeking advice from upstream.

Herald added a subscriber: CnocBride. · View Herald TranscriptJul 25 2018, 14:39
AmandaCath added a comment.Jul 25 2018, 14:46

Someone from upstream says that the following code needs to be used:

$wgExtensionFunctions[] = function() {
    if( array_key_exists( 'checkuser', $GLOBALS['wgGroupPermissions'] ) ) {
        unset( $GLOBALS['wgGroupPermissions']['checkuser'] );
    }
};

However, I am not sure where this code would go in Miraheze’s config.

AmandaCath closed this task as Resolved.Jul 25 2018, 14:59
AmandaCath assigned this task to Paladox.

Fixed by paladox in 22db977a07fc

Thanks to Karsten from upstream for supplying the code and thanks to paladox for implementing it.