Page MenuHomeMiraheze
Create Task
Maniphest T1702

Review Timeless and DarkVector skins
Closed, ResolvedPublic
Actions

Description

Per T1701, the DarkVector and Timeless skins need a security review.

Related Objects
Search...

Event Timeline

• Amanda created this task.Apr 22 2017, 18:24
Herald removed a subscriber: • Amanda. · View Herald TranscriptApr 22 2017, 18:24
• Amanda mentioned this in T1701: Add skins to https://grandtheftauto.miraheze.org.Apr 22 2017, 18:25
ImBoPhil added a comment.Apr 24 2017, 18:21

DarkVector has already been declined per T336.

ImBoPhil renamed this task from Review DarkVector and Timeless skins to Review Timeless skin.Apr 24 2017, 18:21
• Amanda added a comment.Apr 24 2017, 20:39
In T1702#31668, @ImBoPhil wrote:

DarkVector has already been declined per T336.

Not the case - see comment by @Void on parent task

• Amanda renamed this task from Review Timeless skin to Review Timeless and DarkVector skins.Apr 24 2017, 20:40
• Amanda mentioned this in T1746: Install skins Timeless and Foreground on corydoctorow.miraheze.org.May 1 2017, 20:38
labster moved this task from Backlog to Reviewed, Approved on the Extensions board.May 2 2017, 21:06

Both Skin:DarkVector and Skin:Timeless are approved for install.

There's at least one unnecessary query in Timeless, but that should be a minor thing on almost all wikis. At least Isarra seems aware of how terrible their code is, which is means it's a vast improvement over most extension writers.

labster removed a project: Extension-Review.May 6 2017, 20:23
labster removed labster as the assignee of this task.May 8 2017, 03:31
ImBoPhil mentioned this in Unknown Object (Diffusion Commit).May 8 2017, 19:03
ImBoPhil mentioned this in Unknown Object (Diffusion Commit).May 8 2017, 19:17
ImBoPhil mentioned this in Unknown Object (Diffusion Commit).May 10 2017, 18:55
ImBoPhil mentioned this in Unknown Object (Diffusion Commit).May 10 2017, 19:09
ImBoPhil closed this task as Resolved.May 10 2017, 19:10
ImBoPhil claimed this task.