Description
Status | Assigned | Task | ||
---|---|---|---|---|
Resolved | labster | T2242 Extension requests for apps.miraheze.org | ||
Invalid | None | T2316 Extension requests for puzzle.miraheze.org | ||
Resolved | labster | T2274 Extension requests for unmade.miraheze.org | ||
Declined | None | T2247 Review TopTenPages | ||
Declined | labster | T2793 Review HitCounters |
Event Timeline
This looks interesting and doesn't have a too complicated code. @Samwilson please confirm.
Extension:TopTenPages is approved. However, it's not gonna work without Extension:HitCounters. This was originally WMF written, so the code is still in great shape. So this extension is approved as well, from a security point of view.
From a sysamin point of view, I don't know. We definitely need to think about how many resources this will use, as it's still a query per wiki page hit, even if they are deferred updates (which I think is the jobs queue?). It has a caching layer to help, but we're still not running a Redis, so that won't really help us much.
Actually deferrable updates are not the job queue, it happens at the end of each request. https://www.mediawiki.org/wiki/Manual:Job_queue/For_developers Hm. Maybe a feature request for E:HitCounters would be in order.
Per sysadmin discussion on IRC HitCounters will not be installed because of the number of queries it would require. Thus TopTenPages cannot be used.