Page MenuHomeMiraheze

External Auth on all logins
Closed, ResolvedPublic

Description

Per https://github.com/miraheze/mw-config/blob/master/LocalSettings.php#L417, all logins are being prompted with an external login auth.

Less knowledgeable users may enter their login information which will be sent away from miraheze to an external provider who can in theory decrypt the information. (The implementation is likely not secure as the whole layer isn’t securely designed.)

Publicly disclosed already, and extremely easy to find.

Revisions and Commits

Event Timeline

John triaged this task as Unbreak Now! priority.Feb 1 2018, 11:36
John created this task.
revi mentioned this in Unknown Object (Diffusion Commit).Feb 1 2018, 13:10

For security reasons it may be better to disable this feature for all domains not in staff control.

For security reasons it may be better to disable this feature for all domains not in staff control.

There isn’t a feature to enable/disable. It’s upstream domain stuff which is why the domain has been removed.

Reception123 lowered the priority of this task from Unbreak Now! to High.
Reception123 shifted this object from the S1 Public space to the Restricted Space space.
Reception123 removed subscribers: MacFan4000, Void, Brynda1231 and 4 others.

This is still a concern, as any malicious user could in theory still do this.

revi removed revi as the assignee of this task.Feb 5 2018, 18:15
MacFan4000 mentioned this in Unknown Object (Diffusion Commit).Feb 15 2018, 18:40

FYI, this may also be the cause of >95% of the 503 errors.

@Reception123 fyi you shouldn't have moved this to S2 but changed the policy to allow only Security+me (because I made this task and I could have looked into this way way earlier).

John mentioned this in Unknown Object (Diffusion Commit).Mar 30 2018, 22:46
John mentioned this in Unknown Object (Diffusion Commit).Mar 30 2018, 23:23

Why was this change reverted? This auto-login vector is a security vulnerability (since the custom domains are not under our control) and DoS vector (one auto-login generates more than 250 web requests in just a few seconds. It's impossible to handle those with just 12 virtual cores!).

@Southparkfan because it made logins on all custom domains impossible.

Paladox mentioned this in Unknown Object (Diffusion Commit).Apr 29 2018, 22:59
Paladox mentioned this in Unknown Object (Diffusion Commit).Apr 29 2018, 23:05

3 months for a security task is quite poor now as a FYI for people here.

What's to be done here?

For checking if the domain is being loaded from Miraheze fleet - We're doing stuff like T3062: Crackdown for DNS repo: expired/no longer pointing us and T3063: Crackdown for SSL/mediawiki-config repo: DNS entry no longer points us. Automating would be more 'actionable', though.

We need to get this to work by not auto logging into the wiki's, but we carn't seem to get it working.

Paladox closed this task as Resolved by committing Unknown Object (Diffusion Commit).May 20 2018, 23:21
Paladox added a commit: Unknown Object (Diffusion Commit).
Paladox shifted this object from the Restricted Space space to the S1 Public space.May 20 2018, 23:24