Page MenuHomeMiraheze

ScratchBlocks Extension
Closed, ResolvedPublic

Description

warewiki.miraheze.org

https://www.mediawiki.org/wiki/Extension:ScratchBlocks
add this 'scratchblocks' extension in warewikiwiki

Event Timeline

Ojingtube renamed this task from ScratchBlocks Eextension to ScratchBlocks Extension.Jul 13 2018, 22:57

This extension is a wrapper for a Javascript-based code formatting library. It doesn't do anything PHP-side other than load the required JS and render the parser tags, so I think that's all safe enough (tiny improvements? e.g. htmlspecialchars() is used directly, in stead of e.g. Sanitizer::escapeHtmlAllowEntities()). The javascript library is a submodule, and is pretty far out of date, so that could be updated. I've not delved into the details of that though, so if there's no missing functionality then perhaps all is fine.

All up, I'd say this is okay to install, but in an ideal world the submodule would be updated (and there's some coding standard inconsistencies, but that doens't matter).

Oh, and the executable bit is set for some reason on run_scratchblocks.js. Shouldn't be.

Paladox mentioned this in Unknown Object (Diffusion Commit).Aug 3 2018, 13:31
Paladox mentioned this in Unknown Object (Diffusion Commit).