Page MenuHomeMiraheze

Extension: TabsCombination (Tabber + Tabs) - The Tabs feature doesn't work
Open, Stalled, NormalPublic

Description

I have installed the Extension: TabsCombination (Tabber + Tabs)

Tabber works fine:

Tabs does not work:
This code...

Displays this...

Rather than this...

Event Timeline

Michaeldakin triaged this task as Normal priority.
AmandaCath added a subscriber: AmandaCath.

Extension bug.

AmandaCath moved this task from Needs Review to Bugs on the Extensions board.Sep 29 2018, 21:56
AmandaCath changed the task status from Open to Stalled.

Likely an extension bug unrelated to Miraheze.

John added a subscriber: John.Oct 11 2018, 13:54

Has this been reported upstream?

Not sure, but if it hasn’t been already, and we can confirm it’s not a Miraheze issue, it should be ASAP.

John removed a project: Upstream.Oct 11 2018, 14:20

Shouldn’t be marked as upstream unless it’s been reported as such

If I change ...->addModuleScripts... to ...->addModules... on line 378 of Tabs.body.php then the tabs do work as expected again (MW 1.31, PHP 7.2.8, Tabs 1.3.2).... sounds like something that needs to be done sysadmin-wise @John @Paladox

@AmandaCath we can't change the extension files, so this would have to be reported upstream.

@AmandaCath we can't change the extension files, so this would have to be reported upstream.

That’s what I thought.

Yeah, it looks like it's a PHP 7.x thing, since not all extensions have been upgraded for it.

@AmandaCath Just FYI it is possible to submit review requests on Wikimedia extensions too with Gerrit (you can also use the online editing system if you want,).