Page MenuHomeMiraheze
Create Task
Maniphest T4382

Special:RequestWikiQueue (partially) broken
Closed, ResolvedPublic
Actions

Description

After the latest update of Extension:CreateWiki, I found out that there are several problems to be fixed on Special:RequestWikiQueue page.

  1. I cannot approve wiki requests when a custom domain is set. - Although I could decline a wiki request or approve wikis without custom domains, I could not approve a wiki request with a custom domain provided (ex. this request); the button is clickable, but the status unchanged.
  2. I can no longer leave comments (from the "request comment" tab) - When I tried to leave a custom (and detailed) comment for my judgement from "request comments" tab, it just failed with an internal error
[eea8fb0da86c1a3041a75b75] 2019-05-19 05:41:15: Fatal exception of type "Wikimedia\Rdbms\DBUnexpectedError"

returned.

Since wiki creation is one of our core functions, it should be fixed as soon as possible, and thus I will mark it as high priority. Thanks in advance.

Event Timeline

The_Pioneer triaged this task as High priority.May 19 2019, 05:56
The_Pioneer created this task.
Herald added subscribers: CnocBride, Reception123. · View Herald TranscriptMay 19 2019, 05:56
The_Pioneer updated the task description. (Show Details)May 19 2019, 05:57
John closed this task as Resolved.May 19 2019, 13:26
John claimed this task.
John subscribed.

2 is an error that is fixed.

1 isn't an error and there is nothing special. The wiki already exists - I have fixed an issue where the error message wasn't displayed.

The_Pioneer reopened this task as Open.EditedMay 20 2019, 02:27

Thanks for your fix, which I have confirmed that it works. However, the thing is, the wiki does NOT exist, with the non-customized URL resulting in error 404 and custom domain resulting in DNS_PROBE_FINISHED_NXDOMAIN.

There's still something wrong - either with the wikicreation function, or the request itself.

John closed this task as Resolved.May 20 2019, 03:24
> $wm = new WikiManager( 'rainfallwiki' );
> var_dump( $wm->checkDatabaseName( 'rainfallwiki' ) );
string(46) "A wiki with that database name already exists."
> SHOW DATABASES LIKE 'rainfallwiki';
stdClass Object
(
    [Database (rainfallwiki)] => rainfallwiki
)

Code works fine.

The_Pioneer added a comment.May 20 2019, 09:06
This comment was removed by The_Pioneer.
John added a project: MediaWiki.Apr 16 2020, 20:57
Herald added subscribers: • Examknow, Void, NDKilla. · View Herald TranscriptApr 16 2020, 20:57