Page MenuHomeMiraheze

"Welcome to 'wiki name'" appears every time the source or visual editor is opened
Closed, ResolvedPublic

Description

Opening up either editor will always show this notice. There should be a cookie that check if the notice has been dismissed and if it is dismissed, it should only appear again after a period of time or it should never show again.

Event Timeline

Hi, I've already raised this issue upstream and will find the ticket later.

RhinosF1 changed the task status from Open to Stalled.Oct 17 2019, 15:43
RhinosF1 moved this task from Backlog to Upstream on the MediaWiki board.
RhinosF1 added a project: Upstream.

I'll see if i can mess with VE at home and see if i can repro this on a self-hosted wiki

I tested this just now, couldn't reproduce on my test wiki but I only installed VE without the ability to switch from each editor. Should I install the rest of the required components for VE?

I tested this just now, couldn't reproduce on my test wiki but I only installed VE without the ability to switch from each editor. Should I install the rest of the required components for VE?

Please

This comment was removed by Void.

Hello, I am new here and would like to first say thank you for the above and beyond, beautiful services.

And on the IRC I was wncouraged to add this detail:

  1. click "Edit source" (dismiss the box)
  2. click "Show Preview" at the bottom of the page (new page loads, box returns)

When it shows up the second time, it's very confusing (at least to me).
Because this displays over top of the preview portion (which is above the source editor), my brain thinks that "visual" is the correct choice. But it's a trick!

Because if you click "Switch to visual editing" you get another dialogue box:

Switch to visual editing?
You are switching to visual editing. Do you want to continue?
[Cancel]
[Discard my changes and switch]

Since as far as I know, saving and re opening for editing is the only way to make sure you don't lose all work, I am doing this all the time. It is very, very obnoxious.

Also, by way of a workaround I tried to hide it with uBlock Origin. It didn't work but probably someone who knows how to use it better than I do could figure it out.

I believe this issue is to do with our frequent downtime/slow loading.

Based on what i found, VisualEditor saves using the API so that it remembers not to show you the prompt next time. But if the API is slow/503's/timesout then it won't save and you'll have it shown to you again.

Andreas changed the task status from Stalled to Open.Dec 1 2019, 18:45
Andreas assigned this task to Paladox.

@Paladox found where this bug is hiding in VE and is submitting a fix upstream...

image.png (69×1 px, 19 KB)

Change pulled and deployed!

The wrong bug seems to have been fixed? The "Welcome to <wiki>" message still appears whenever I open the edit window.

Yeh, i only read https://phabricator.miraheze.org/T4813#94037 which i why i closed this as resolved thinking it was the bug todo with VS returning 0.

We could try setting a default preference for all users to see if that allows this to work properly.