Page MenuHomeMiraheze

protect methods for direct database modification
Closed, ResolvedPublic

Description

Methods that directly modify the database should not be public.
So far, some methods where protected, some where public, in some
cases misleading LoadExtensionSchemaUpdates handlers to call them
directly, leading to dangerous behavior.

The following methods are affected:

dropTable
modifyTable
modifyField
runMaintenance

See https://phabricator.wikimedia.org/T249603

  • CreateWiki: modifyTable, modifyField
  • ManageWiki: modifyTable
  • MatomoAnalytics: modifyTable
  • MirahezeMagic: modifyField