This is causing the jobrunner to get backed up so this should be fixed ASAP.
if you do:
select * from mw_permissions where perm_addgroups = 'null';
or
select * from mw_permissions where perm_removegroups = 'null';
It will show many results.
@Paladox thought they had fixed this bug but appears not.
| Status | Assigned | Task | ||
|---|---|---|---|---|
| Resolved | Paladox | T5697 perm_addgroups and perm_removegroups keep getting set to 'null' | ||
| Resolved | AmandaCath | T5696 Problem with the Changing of User Rights |
Raising to UBN!
The job queue being backed up causes delays in echo.
That means users won't be notified about wiki creations until potentially hours later (very possible) and things like login notify. There is probably a lot more I'm missing.
That's a critical service to me.
additionally it appears it's saving perm_permissions as an object rather than an array.
My investigation has found that the issue only happens when switching a wiki from private to public. Therefore https://github.com/miraheze/ManageWiki/blob/67978e128890b7485bd9906bbf93b624256d7b52/includes/ManageWikiHooks.php#L249 is the issue.
Also if this has been happening for a while, why was no report filed the first or second time? Why only a month later and multiple database fixes (which by the way is a big no-no as I have said numerous times)
@Paladox I’d really like a reply to this as frankly, I’m getting tired of repeating the latter point to SRE now
I did report this previously... but i thought i fixed it (T5660).
Anyways switching between public and private now works (tested on test2 which is where i managed to reproduce).
I asked you to reply to two parts, you replied to the part I was least concerned about.
“ Why [...] multiple database fixes (which by the way is a big no-no as I have said numerous times)”
@John Oh, well i was experimenting with test2 to reproduce but i have no excuses for worldtrainwikiwiki so apologies. I was thinking about the best way to fix the rest.
That doesn’t even come close to answering my questions satisfactory. But I’m taking this to email now anyway