Page MenuHomeMiraheze

Skin Review: Onyx
Closed, DeclinedPublic

Description

Is it possible, I could get this skin approved?
https://github.com/Halopedia/Onyx
In addition to that, can you please remove 'skin' from hiddenprefs?

Event Timeline

Unknown Object (User) created this task.Jul 20 2020, 01:50

I have submitted a change to remove the skin from $wgHiddenPrefs on your wiki.

As noted indirectly by Hispano76, the other skin will need security review (although I will say that a lack of a MediaWiki.org documentation page is a minor red flag by itself).

Reception123 renamed this task from New skin approval to Skin Review: Onyx.Jul 24 2020, 05:20
Unknown Object (User) closed this task as Declined.EditedAug 25 2020, 02:57
Unknown Object (User) claimed this task.

Declining the skin (which I personally requested awhile ago). It accesses the database, which is not recommended for a skin to do. In addition, per a conversation I had with the skin's developer, there are improvements planned that will remove that functionality, factor it into an extension. As well as make the codebase more readable through use of mustache engine. Additionally, the skin uses not recommended method of cookie set and get for the sitenotice, which has performance issues. The sitenotice uses cookies from JavaScript rather then the PHP method of $_COOKIE or the even more recommended method of $wgRequest->getCookie. While the use of $wgRequest is not the most ideal way of doing it, as when avoidable global variables are not recommended, it does give a good idea what I mean. While the cookies way in itself is not reasoning enough for decline, the planned features, plus the database access is reason to postpone it. It may be re-submited for review if this is fixed later on.