Page MenuHomeMiraheze
Create Task
Maniphest T6051

Extension:LunarFunctions
Closed, DeclinedPublic
Actions

Description

Wiki URLmagic.miraheze.org

https://www.mediawiki.org/wiki/Extension:LunarFunctions

Please install extension. Thank you in advance.

This ticket relayed to https://phabricator.miraheze.org/T5975 Extension:MediaWiki-CalendarConverter

Related Objects

Event Timeline

Helper created this task.Aug 15 2020, 10:09
Herald added subscribers: RhinosF1, Void, Reception123, NDKilla. · View Herald TranscriptAug 15 2020, 10:09
Hispano76 edited projects, added Extensions; removed MediaWiki.Aug 15 2020, 13:20
Hispano76 moved this task from Backlog to Security Review Needed on the Extensions board.
Unknown Object (User) claimed this task.Aug 25 2020, 21:29
Herald added a project: Universal Omega. · View Herald TranscriptAug 25 2020, 21:29
Unknown Object (User) added a comment.Aug 25 2020, 23:14

Looks good to me. Although I have not tested for compatibility with 1.35 (Upcoming release (LTS)).

Reception123 added a comment.Aug 26 2020, 04:56
In T6051#119180, @Universal_Omega wrote:

Looks good to me. Although I have not tested for compatibility with 1.35 (Upcoming release (LTS)).

Well compatibility isn't really part of the security reviewer's job :) So is this considered approved then?

Unknown Object (User) moved this task from Security Review Needed to Reviewed, Approved on the Extensions board.Aug 26 2020, 05:07
In T6051#119184, @Reception123 wrote:
In T6051#119180, @Universal_Omega wrote:

Looks good to me. Although I have not tested for compatibility with 1.35 (Upcoming release (LTS)).

Well compatibility isn't really part of the security reviewer's job :) So is this considered approved then?

Yep. I'm aware compatibility is not part of the job. I just do usually test compatibility in order to make things easier, hopefully. But yes. No issues in the extension itself.

Unknown Object (User) removed Unknown Object (User) as the assignee of this task.Aug 26 2020, 05:12
Unknown Object (User) subscribed.
Unknown Object (User) claimed this task.EditedAug 26 2020, 05:16
Unknown Object (User) moved this task from Reviewed, Approved to Security Review Needed on the Extensions board.

Looking at one thing before I decide whether to approve or not with this.

Putting this task on hold temporarily.

Unknown Object (User) added a comment.Sep 3 2020, 22:47

Do you still need this extension? You did request quite a bit similar extensions, so just double checking.

Unknown Object (User) moved this task from Security Review Needed to Reviewed, Approved on the Extensions board.Sep 4 2020, 00:13
Unknown Object (User) removed Unknown Object (User) as the assignee of this task.Sep 4 2020, 00:17
Helper added a comment.Sep 4 2020, 01:07

Yes, I still need it. Since the all moon phases / lunar calendar extensions were declined, I am in search for solution.

Unknown Object (User) added a comment.Sep 4 2020, 01:16
In T6051#119982, @Helper wrote:

Yes, I still need it. Since the all moon phases / lunar calendar extensions were declined, I am in search for solution.

Thank you for the response! I've approved the extension. Hopefully a system admin will be able to install it tomorrow.

Unknown Object (User) claimed this task.Sep 4 2020, 03:22

I submitted a pull request to add this extension. Just awaiting System admin's installation now.

Unknown Object (User) changed the task status from Open to Stalled.EditedSep 4 2020, 05:05

Declining, for now due to installation difficulties, the subdmodule won't work on the format of this extension's path.

The extension will need to be moved to its own repository before approval is possible.

Unknown Object (User) closed this task as Declined.Sep 5 2020, 15:14