Page MenuHomeMiraheze

FlaggedRevsRestrictionLevels not working as expected
Closed, DeclinedPublic

Description

I recently enabled FlaggedRevs $wmgFlaggedRevsProtection on Special:ManageWiki, as I am looking to have Wikipedia style protection-based implementation of FlaggedRevs.
From that point I was able to either set the protection level of a page between either "Allow all users" and "flaggedrevs-protect-sysop". I have a user group "Reviewers" that I would like to have bypass the review process, so I added Reviewer to $wmgFlaggedRevsRestrictionLevels.
As expected, I then saw "flaggedrevs-protect-reviewer" as an available option when setting the protection level of a page, but upon attempting to confirm the change, I was met with red text at the top of the protection screen stating "Permission denied." What am I doing wrong here?

Event Timeline

Yeah, I was thinking about the FlaggedRevs extension recently, actually. English Wikipedia uses this for Pending Changes protection, and it only impacts non-autoconfirmed users. It really shouldn't be enabled by default on all pages or in all namespaces. In my view, when this extension is enabled, it should be configured, by default, as a pending changes protection level and only applied on pages or in namespaces set to this protection level. Otherwise, we are really duplicating things with patrolled/unpatrolled revisions and flagged revisions.

Reception123 triaged this task as Normal priority.Sep 24 2020, 13:59
Unknown Object (User) closed this task as Declined.Nov 1 2020, 02:55
Unknown Object (User) claimed this task.

I've submitted a pull request to remove this setting from ManageWiki. It is not actually supported by ManageWiki for the same reason that $wgRestrictionLevels is not, it uses user rights, not usergroups. https://github.com/wikimedia/mediawiki-extensions-FlaggedRevs/blob/5904212d4ec3cb3a56b8bb493b8ba57f644f628e/backend/FlaggedRevs.php#L478

Changing this to stalled, as that status seems appropriate, as ultimately we do want and need to implemented protection levels with Flagged Revisions as that extension was never intended to be used on every page always. It is designed to work with a protection level. If we need to use protection levels instead of restriction levels, that's fine, but we definitely need to do something.

Unknown Object (User) closed this task as Declined.Nov 2 2020, 01:37

Changing back to declined, while yes this is something we will want. At the current state of ManageWiki, not only is this impossible but this specific task was originally for asking why it isn't working in ManageWiki. I would recommend an entire different task for the feature request to be added. That way it can be kept in-scope and can also target $wgRestrictionLevels itself.

Okay, fair enough. Thanks! :)