Page MenuHomeMiraheze

Update configuration for MirahezeMagic interwiki wikilinks to apply to log actions, edit summaries, and page previews
Closed, ResolvedPublic

Description

Issue: I was discussing this with @Reception123 a few weeks back when I wondered whether we should have a MirahezeMagic project on Phabricator, and he suggested I use either Configuration or MediaWiki for now. Anyway, the MirahezeMagic interwiki wikilinks that take the form of [[mh:subdomain:pageName|optional piped link]] only display on pages, not in log actions or edit summaries or when previewing the page. It may be more challenging to update this when previewing the page, so if that can't be done, I would be okay with that, but would love to this fixed so we link to specific pages or diffs on other Miraheze wikis in our log actions and edit summaries.

Problem: In log actions, edit summaries, and when previewing the page, the MirahezeMagic interwiki wikilinks appear as redlinks to non-existent pages on that wiki (i.e., Mh:subdomain:pagename|optional piped link).

Reproducable? Yes, on any Miraheze wiki.

What should happen: Instead of formatting the link as a redlink to a non-existent page on the local wiki in log actions, edit summaries, and, ideally, when previewing the page, the MirahezeMagic interwiki wikilinks should be displayed as they would on a page, as interwiki links to the referenced Miraheze customer wiki.

Event Timeline

Dmehus triaged this task as Normal priority.Sep 24 2020, 21:15
Dmehus created this task.
Dmehus updated the task description. (Show Details)

And why can I never use code blocks on Phabricator tickets anymore? It used to work by using three apostrophes (to left of the 1 key) inline. Now it only seems to work when the code block is in a separate paragraph on its own. This is undesirable behaviour, sub-optimal, and probably should be fixed.

And why can I never use code blocks on Phabricator tickets anymore? It used to work by using three apostrophes (to left of the 1 key) inline. Now it only seems to work when the code block is in a separate paragraph on its own. This is undesirable behaviour, sub-optimal, and probably should be fixed.

`inline code` (a single backtick on each side) should work

working example: inline code

Universal_Omega lowered the priority of this task from Normal to Low.Dec 23 2020, 06:56

It is not due to configuration but rather the way the interwiki feature has been implemented in MirahezeMagic. The feature relies on the HtmlPageLinkRendererEnd hook which uses the LinkRenderer class which is why the links are properly rendered only when viewing the page preview (the title and description of this task are either outdated or were never valid) or the page after saving the edit. Some other hook needs to be used to implement this feature.

Should now be fixed. Will be made live when MirahezeMagic is updated.

@Universal_Omega, thank you. I'm quite happy with this fix. This qualifies for the rare party time token, I think, as this is easily the Phabricator task I most wanted to be completed. Surprisingly, it ended up not being many lines of code to fix.