Page MenuHomeMiraheze

Request to have undeletable files deleted - All The Tropes
Closed, ResolvedPublic

Description

We have discovered a database error on All The Tropes that is preventing us from deleting some but not all unused files. The files in question have all been uploaded more than once, with no thumbnail available for the first version uploaded.

So far, we have discovered 468 of these files, all of which are listed at https://allthetropes.org/wiki/Category:Undeletable_files

Please delete the files listed there via the database backend. Please do not delete the category page - we are still going through the old files and identifying some that are not being used and do not have CC licenses.

Event Timeline

Reception123 triaged this task as Normal priority.Sep 26 2020, 06:29
Reception123 added a project: MediaWiki.

For reference for sysadmins:

[26-Sep-2020 06:38:27 UTC] PHP Fatal error:  Uncaught Wikimedia\Rdbms\DBAccessEr                                                                             ror: Database access has been disabled. in /srv/mediawiki/w/includes/libs/rdbms/                                                                             loadbalancer/LoadBalancer.php:1265
Stack trace:
#0 /srv/mediawiki/w/includes/libs/rdbms/loadbalancer/LoadBalancer.php(1094): Wik                                                                             imedia\Rdbms\LoadBalancer->reallyOpenConnection(Array, Object(Wikimedia\Rdbms\Da                                                                             tabaseDomain))
#1 /srv/mediawiki/w/includes/libs/rdbms/loadbalancer/LoadBalancer.php(926): Wiki                                                                             media\Rdbms\LoadBalancer->getLocalConnection(0, 4)
#2 /srv/mediawiki/w/includes/libs/rdbms/loadbalancer/LoadBalancer.php(898): Wiki                                                                             media\Rdbms\LoadBalancer->getServerConnection(0, 'allthetropeswik...', 4)
#3 /srv/mediawiki/w/includes/libs/rdbms/loadbalancer/LoadBalancer.php(1043): Wik                                                                             imedia\Rdbms\LoadBalancer->getConnection(-2, Array, 'allthetropeswik...', 4)
#4 /srv/mediawiki/w/includes/GlobalFunctions.php(2556): Wikimedia\Rdbms\LoadBala                                                                             ncer->getMaintenanceConnectionRef(-2, Array, 'allthetropeswik...')
#5 /srv/mediawiki/w/includes/filerepo/LocalRepo.php(488): wfGetDB(-2)
#6 /srv/mediawiki/w/include in /srv/mediawiki/w/includes/libs/rdbms/loadbalancer                                                                             /LoadBalancer.php on line 1265

@John Would you have any idea why this is happening and how this could be resolved? deleteBatch.php didn't work either.

All images on All The Tropes (excepting images hosted on Wikimedia Commons) are now not visible on all pages. Is that a result of the efforts being made to solve this issue, or should I enter another Phabricator ticket for that?
EDIT: Sorry, this issue was at my end. The issue with certain images being undeletable remains.

All images on All The Tropes (excepting images hosted on Wikimedia Commons) are now not visible on all pages. Is this a result to the efforts being made to solve this issue, or should I enter another Phabricator ticket for that?

Yes, we are trying to figure out a way to be able to zip the files as we're getting I/O errors. Sorry for the inconvenience, it should hopefully be fixed shortly.

Oh sorry, I misread this and was under the impression that this task was relating to the zipping of the images requested by GethN7. The issues with the images were not related to fixing the deletion issue, but they should be fixed.

It's been nearly a month since I reported this. Has there been any progress?

Unknown Object (User) added a comment.Nov 18 2020, 07:14

I believe this is caused because there is no old file for the file history.
Supported by the error Unexpected value: "oldimage"="". as well as by the findings of https://www.mediawiki.org/wiki/Topic:Vqouxwx3l92nmcnw

Unknown Object (User) claimed this task.Dec 5 2020, 23:26

Fixed so they can now be deleted. Will run deleteBatch shortly

Unknown Object (User) closed this task as Resolved.Dec 6 2020, 00:12
Unknown Object (User) removed Unknown Object (User) as the assignee of this task.

All files in the category have now been deleted. And you should not have the issue in the future. All files should now be deletable.

Unknown Object (User) claimed this task.Dec 6 2020, 00:12
Unknown Object (User) moved this task from Bugs to Maintenance Script Run on the MediaWiki board.

Confirmed - I just deleted a file that I expected from a lack of thumbnail would have been undeletable.

Thank you for the help. I believe this can be closed now.

Unknown Object (User) added a comment.Dec 9 2020, 17:15

Confirmed - I just deleted a file that I expected from a lack of thumbnail would have been undeletable.

Thank you for the help. I believe this can be closed now.

I am glad everything is resolved now. If anymore issues please don't hesitate to reopen this task or create another.