Multiple users have reported their wikis being marked closed (later found out by our script) when they’ve recently made actions on the wiki.
Revisions and Commits
While not necessarily related a user said that when they attempted to reopen a wiki it gave the error "The value you specified is not a valid option." but when I reopened it caused internal errors similar to P348 ([81d8e6546aaff16ec7c46e11] 2020-11-04 16:19:35: Fatal exception of type "LogicException")
Paladox #Biden2020 it does that because you can chose the db cluster, we only set 2 (db11 and db12) not db13. Paladox #Biden2020Today at 5:23 PM thus it defaults to c2 so if you save on /core you'll change the cluster
Including comments made by @Paladox in #general on Discord (relating to the internal error aspect of this task)
I've looked into this, and I can't seem to be able to reproduce the problem on *any* wiki listed above. Every wiki listed activates https://github.com/miraheze/CreateWiki/blob/6f6d3312ea7459b377b8c2c659888b770119ddd5/maintenance/manageInactiveWikis.php#L80, which does nothing as the wiki is active.
I've looked into this from every angle and I can't find the cause, but more importantly, I can't prove there is an issue. The script works 100% as expected when running it - the wikis listed above aren't inactive and the script reflects that, the wikis it did say are inactive - are inactive, and the wikis it said are eligible for closing - are.
I don't know, but it is absolutely nothing wrong with the script as I just ran it and it worked entirely as expected.
If people had done some debugging at the time, it may have helped rather than leaving it days for me to be able to look myself - if someone had run the script or even the code inside the script of a relevant wiki, it would have potentially useful information.
We wait after restarting the cron and see if there's any issue in the next few days and then someone online checks the log.
If the problem goes away and doesn't come back after a week, then yes it's invalid.
Just because you have no explanation, that doesn't make it invalid.
I have ran the script - the problem isn't there. I have ran the code line-by-line, the problem isn't there. I have debugged all possible explanations - I can't find either a cause or a problem.
root@jobrunner1:~# php /srv/mediawiki/w/maintenance/eval.php --wiki loginwiki
$ts = (int)MediaWiki\Shell\Shell::makeScriptCommand( '/srv/mediawiki/w/extensions/CreateWiki/maintenance/checkLastWikiActivity.php', [ '--wiki', 'comiccrossroadswiki' ] )->limits( [ 'memory' => 0, 'filesize' => 0 ] )->execute()->getStdout();
var_dump( $ts > date( 'YmdHis', strtotime( '-15 days' ) ) );
Line 80 is active, and from my earlier noop script run - comiccrossroadswiki wasn't eligible for closing. Therefore, I am 100% positive yet again the script isn't the problem.
Also the cron hasn't ran yet - it was re-enabled after 12pm today - so won't run until tomorrow.