Page MenuHomeMiraheze

Script closing wikis when it shouldn’t
Closed, InvalidPublic

Description

Multiple users have reported their wikis being marked closed (later found out by our script) when they’ve recently made actions on the wiki.

Event Timeline

Zppix triaged this task as Normal priority.Tue, Nov 3, 16:39
Zppix created this task.
Zppix edited projects, added CreateWiki; removed ManageWiki.

Actually seems CW handles this

Zppix removed Zppix as the assignee of this task.EditedTue, Nov 3, 17:06
Zppix updated the task description. (Show Details)

Im at a lost, my first theory was the script was being ran on both jobrunners, but as Paladox pointed out its not.

Which wikis? Without anything to look at, I can't investigate this issue.

In T6403#125420, @John wrote:

Which wikis? Without anything to look at, I can't investigate this issue.

On

In Hispano76wiki, it was marked as closed again.

Reception123 raised the priority of this task from Normal to High.Wed, Nov 4, 16:02

funkeywiki has also experienced this issue.

Moving to high priority as this seems to be negatively affecting many wikis and confusing users.

While not necessarily related a user said that when they attempted to reopen a wiki it gave the error "The value you specified is not a valid option." but when I reopened it caused internal errors similar to P348 ([81d8e6546aaff16ec7c46e11] 2020-11-04 16:19:35: Fatal exception of type "LogicException")

Paladox #Biden2020
it does that because you can chose the db cluster, we only set 2 (db11 and db12) not db13.

Paladox #Biden2020Today at 5:23 PM
thus it defaults to c2 so if you save on /core you'll change the cluster

Including comments made by @Paladox in #general on Discord (relating to the internal error aspect of this task)

Unexpected wiki closure occured yesterday and today on Christipedia.miraheze.org. Both times I than reopened the wiki at https://christipedia.miraheze.org/wiki/Speciaal:ManageWiki/core

Zppix raised the priority of this task from High to Unbreak Now!.Thu, Nov 5, 03:16

Seems to still be closing wikis

John lowered the priority of this task from Unbreak Now! to High.Thu, Nov 5, 06:09

Disable the script if it’s not functioning properly, this isn’t an unbreak now kind of task. It probably doesn’t even qualify for high personally

@John A side note question, apparently some are saying that their wiki has still been closed after I absented the script. Is that possible? If so should it be commented out in addition?

@John A side note question, apparently some are saying that their wiki has still been closed after I absented the script. Is that possible? If so should it be commented out in addition?

If the script has been removed from cron in puppet, either a) someone is running it, b) the wikis were closed before or c) it’s still in cron

I've looked into this, and I can't seem to be able to reproduce the problem on *any* wiki listed above. Every wiki listed activates https://github.com/miraheze/CreateWiki/blob/6f6d3312ea7459b377b8c2c659888b770119ddd5/maintenance/manageInactiveWikis.php#L80, which does nothing as the wiki is active.

I'm running the script as well, and all closures/inactive notices seem correct to me so far.

I've looked into this from every angle and I can't find the cause, but more importantly, I can't prove there is an issue. The script works 100% as expected when running it - the wikis listed above aren't inactive and the script reflects that, the wikis it did say are inactive - are inactive, and the wikis it said are eligible for closing - are.

@John: Well, how come wikis ended up closed that shouldn't have been.

@John: Well, how come wikis ended up closed that shouldn't have been.

I don't know, but it is absolutely nothing wrong with the script as I just ran it and it worked entirely as expected.

If people had done some debugging at the time, it may have helped rather than leaving it days for me to be able to look myself - if someone had run the script or even the code inside the script of a relevant wiki, it would have potentially useful information.

Then the task isn't invalid, we just don't have a solution or explanation for whatever caused it.

Then the task isn't invalid, we just don't have a solution or explanation for whatever caused it.

I'm open to alternative closure states

We wait after restarting the cron and see if there's any issue in the next few days and then someone online checks the log.

If the problem goes away and doesn't come back after a week, then yes it's invalid.

Just because you have no explanation, that doesn't make it invalid.

If the problem goes away and doesn't come back after a week, then yes it's invalid.

I have ran the script - the problem isn't there. I have ran the code line-by-line, the problem isn't there. I have debugged all possible explanations - I can't find either a cause or a problem.

Who ran the script? I see nothing in the logs - I ran it in noop mode.

root@jobrunner1:~# php /srv/mediawiki/w/maintenance/eval.php --wiki loginwiki

$ts = (int)MediaWiki\Shell\Shell::makeScriptCommand( '/srv/mediawiki/w/extensions/CreateWiki/maintenance/checkLastWikiActivity.php', [ '--wiki', 'comiccrossroadswiki' ] )->limits( [ 'memory' => 0, 'filesize' => 0 ] )->execute()->getStdout();

var_dump( $ts > date( 'YmdHis', strtotime( '-15 days' ) ) );

bool(true)

Line 80 is active, and from my earlier noop script run - comiccrossroadswiki wasn't eligible for closing. Therefore, I am 100% positive yet again the script isn't the problem.

Also the cron hasn't ran yet - it was re-enabled after 12pm today - so won't run until tomorrow.

Also, the last change to the script was ~18 days before the problem was reported.

We still don't know why wikis are being closed randomly.
Even if isn't the script. Something is.

We also have the same issue. It happened today. I'm glad you guys are investigating this.