Page MenuHomeMiraheze
Create Task
Maniphest T6510

Remove global echo notifications from deleted wikis
Closed, ResolvedPublic
Actions

Description

I'd definitely call this a very low priority task, and maybe is even not worth it if it's very complex to do.

Basically, if a user doesn't mark a notification as read on a wiki and that wiki is subsequently deleted, the user will retain a Meta "residue" of that notification and will be unable to mark it as read afterwards since it says "No sitename set", so therefore will be stuck with unread notifications forever.

The solution for that issue is to delete the entry from echo_unread_wikis, so I was thinking this should be made into an automatic process which is integrated in one of the scripts in charge of deleting wikis/marking wikis as deleted, so that once a wiki is deleted, its entry from that table is removed. So something like DELETE FROM echo_unread_wikis WHERE euw_wiki = 'xwiki';

(See T6509 for the bug that was reported and fix, for reference)

Related Objects

Event Timeline

Reception123 triaged this task as Low priority.Nov 27 2020, 19:28
Reception123 created this task.
Herald added a project: Universal Omega. · View Herald TranscriptNov 27 2020, 19:28
Herald added subscribers: Unknown Object (User), RhinosF1. · View Herald Transcript
Reception123 moved this task from Backlog to Features on the CreateWiki board.Nov 27 2020, 19:29
Reception123 updated the task description. (Show Details)
John edited projects, added MediaWiki; removed CreateWiki.Nov 27 2020, 19:52
John subscribed.

https://github.com/miraheze/MirahezeMagic/blob/master/includes/MirahezeMagicHooks.php#L30

Herald added subscribers: Void, NDKilla. · View Herald TranscriptNov 27 2020, 19:52
Dmehus subscribed.EditedNov 27 2020, 20:26

👍 to this. Funnily enough, I just suggested this @Reception123 on Discord in my reply to him in a direct message. Something like a simple maintenance script that could be run on request by system administrators would be awesome.

Unknown Object (User) claimed this task.Dec 8 2020, 23:08

https://github.com/miraheze/MirahezeMagic/pull/172/

MacFan4000 subscribed.Dec 10 2020, 17:32

I think we should probably do something similar for renaming wikis. If a wiki is renamed, then users are stuck with notifications for the old dbname. So we should either the dbname update all of the references in the echo_unread_wikis for the old dbname to the new dbname, or else delete the references.

Unknown Object (User) closed this task as Resolved.EditedDec 30 2020, 19:38

Done for both rename and deletions. Will be deployed once MirahezeMagic is updated.

  • It deletes it from global database on wiki deletion
  • It updates the table to rename the old database to the new on for echo notifications on wiki rename
Dmehus awarded a token.Dec 30 2020, 23:25
Hispano76 subscribed.EditedJan 14 2021, 23:22

In my HispanoBOT alternative account, I still receive the same notification from a non-existent wiki (since 3 years ago). This is not related to the task? @Universal_Omega

Captura de pantalla 2021-01-14 171322.jpg (174×504 px, 10 KB)

MacFan4000 added a comment.Jan 20 2021, 20:21

@Hispano76 somebody will have to take care of that in the DB then.

Unknown Object (User) added a comment.Jan 20 2021, 20:24
In T6510#132425, @Hispano76 wrote:

In my HispanoBOT alternative account, I still receive the same notification from a non-existent wiki (since 3 years ago). This is not related to the task? @Universal_Omega

Captura de pantalla 2021-01-14 171322.jpg (174×504 px, 10 KB)

What @MacFan4000 said. My update/fix only effects new wikis/notifications since it was added, not existing ones before the change was made.

Hispano76 mentioned this in T7015: Phantom" notification from a private wiki, TurtleWiki.Mar 21 2021, 22:03