Page MenuHomeMiraheze

Flow/StructuredDiscussions content model no longer appears as a selectable option in Special:ManageWiki/namespaces
Closed, ResolvedPublic

Description

Bug report: The Flow/StructuredDiscussions content model no longer appears as a selectable option in Special:ManageWiki/namespaces, making it impossible for wikis to set it as the default content model across namespaces, whereas this functionality previously existed prior to recent ManageWiki/namespaces improvements.

Reproducable? Yes

Reproduced by: Reported by @MarioMario456 and reproduced by @Lakelimbo and myself

Thanks.

Event Timeline

Dmehus triaged this task as High priority.Mar 29 2021, 19:58
Dmehus created this task.

I was also able to reproduce this issue on my wiki.

Universal_Omega removed a project: Configuration.
Universal_Omega moved this task from Backlog to Bugs on the ManageWiki board.
Universal_Omega moved this task from Unsorted to Short Term on the Universal Omega board.
NOTE: The above PR was closed after conversation on IRC.

My recent changes/improvements to Special:ManageWiki/namespaces (https://github.com/miraheze/ManageWiki/pull/255) made all available content models be auto available from MWN, while excluding those content models, not meant for direct editing, and not available from Special:ChangeContentModel. This ended up including the flow content model, as its not meant to be individually changed like that. Issues could arise by changing to the flow content model on individual namespaces, from that, as has happened in the past. Due to the fact that this is an intentional change, and one that we may or may not want to include flow as part of content models from Special:ManageWiki/namespaces, I'm not entirely sure how to proceed here.

Universal_Omega lowered the priority of this task from High to Normal.Mar 29 2021, 21:17
Universal_Omega moved this task from Bugs to Features on the ManageWiki board.

This is technically expected behaviour.

This is technically expected behaviour.

@Universal_Omega Any idea why the Flow/StructuredDiscussions content model existed in Special:ManageWiki/namespaces before, though?

This is technically expected behaviour.

@Universal_Omega Any idea why the Flow/StructuredDiscussions content model existed in Special:ManageWiki/namespaces before, though?

Before it was manually added there. Now that namespaces autodetects which ones should be there, it isn't there anymore.

This is technically expected behaviour.

@Universal_Omega Any idea why the Flow/StructuredDiscussions content model existed in Special:ManageWiki/namespaces before, though?

Before it was manually added there. Now that namespaces autodetects which ones should be there, it isn't there anymore.

Oh, and why did we change that? It was working before, as long as users didn't mess up and select the wrong content model (but that's fixable).

This is technically expected behaviour.

@Universal_Omega Any idea why the Flow/StructuredDiscussions content model existed in Special:ManageWiki/namespaces before, though?

Before it was manually added there. Now that namespaces autodetects which ones should be there, it isn't there anymore.

Oh, and why did we change that? It was working before, as long as users didn't mess up and select the wrong content model (but that's fixable).

It was changed so that it adds all content models that should be selectable, not only some. It now shows all content models in MWN options, as are available in Special:ChangeContentModel. Flow was never meant to be changed from there.

This is technically expected behaviour.

@Universal_Omega Any idea why the Flow/StructuredDiscussions content model existed in Special:ManageWiki/namespaces before, though?

Before it was manually added there. Now that namespaces autodetects which ones should be there, it isn't there anymore.

Oh, and why did we change that? It was working before, as long as users didn't mess up and select the wrong content model (but that's fixable).

It was changed so that it adds all content models that should be selectable, not only some. It now shows all content models in MWN options, as are available in Special:ChangeContentModel. Flow was never meant to be changed from there.

Right, except the issue is that wikis want to be able to enable Flow in an entire namespace or all talk namespaces, so we need to figure out how to reimplement this.

Wait, actually, looking at the extension page, it looks like it was designed to be set by namespace:

// These lines enable StructuredDiscussions on the "Talk" and "User talk" namespaces
 // All the NS_* constants here: https://www.mediawiki.org/wiki/Manual:Namespace_constants
 
 $wgNamespaceContentModels[NS_TALK] = 'flow-board';
 $wgNamespaceContentModels[NS_USER_TALK] = 'flow-board';

Wait, actually, looking at the extension page, it looks like it was designed to be set by namespace:

// These lines enable StructuredDiscussions on the "Talk" and "User talk" namespaces
 // All the NS_* constants here: https://www.mediawiki.org/wiki/Manual:Namespace_constants
 
 $wgNamespaceContentModels[NS_TALK] = 'flow-board';
 $wgNamespaceContentModels[NS_USER_TALK] = 'flow-board';

Yes, I just realised that.

Universal_Omega raised the priority of this task from Normal to High.Mar 30 2021, 05:03
Universal_Omega moved this task from Features to Bugs on the ManageWiki board.

Due to what dmehus said, and I realised, this is actually a bug. So reverting to original workboard section and priority.

Now available from Special:ManageWiki/namespaces again, as Flow-board at the moment.

Due to what dmehus said, and I realised, this is actually a bug. So reverting to original workboard section and priority.

Sounds good.

Now available from Special:ManageWiki/namespaces again, as Flow-board at the moment.

Thanks! I already awarded my token when you initiated the PR, so I'll just thank you for resolving this bug quickly. :)