Page MenuHomeMiraheze
Create Task
Maniphest T7117

Upgrade to MediaWiki 1.36.0
Closed, ResolvedPublic
Actions

Assigned To
Unknown Object (User)
Authored By
RhinosF1
Apr 8 2021, 22:35
Tags
Referenced Files
None
Subscribers
Anton
Bukkit
Dmehus
Joritochip
Lakelimbo
MacFan4000
NDKilla
View All 13 Subscribers
Tokens
"Like" token, awarded by Dmehus."Like" token, awarded by Bukkit."Cup of Joe" token, awarded by Redmin."Cup of Joe" token, awarded by PiscesKazeMGR.

Description

Notes:

Config: https://github.com/miraheze/mw-config/tree/REL1_36
MediaWiki: https://github.com/miraheze/mediawiki/tree/REL1_36

rc-0 -> test3 blockers:

  • @RhinosF1 to complete re-implementing X-Device work and get @Southparkfan's approval
  • @RhinosF1 to resync config branch
  • Convert core sql to list to actual commands
  • take a backup of test3
  • @Reception123 to sync MediaWiki repo

Production blockers:
The 1.36 update is currently blocked by 4 issues.

Production upgrade (at 19:00 UTC 12 June 2021):

Related Objects
Search...

StatusAssignedTask
 ResolvedJohnT7139 MediaWiki Capacity Proposal
 ResolvedReception123T7450 Evaluate what happened during the 1.36 update
 ResolvedUnknown Object (User)T7117 Upgrade to MediaWiki 1.36.0
 ResolvedReception123T7116 Consider installing SecureLinkFixer
 ResolvedUnknown Object (User)T7253 Disable Modern Vector in 1.36 by default, Slow roll eventually
 ResolvedUnknown Object (User)T7357 Apply test3 drop default schema changes
 ResolvedRhinosF1T7358 Enable wgCheckUserEnableSpecialInvestigate
 ResolvedUnknown Object (User)T7359 Test all extensions for 1.36
 ResolvedUnknown Object (User)T7383 Consider undeploying ModernSkylight skin
 DeclinedUnknown Object (User)T7389 Switch PortableInfobox repository
 DeclinedUnknown Object (User)T7360 Remove Variables
 ResolvedUnknown Object (User)T7387 Consider enabling logging of CU data for logins
 ResolvedUnknown Object (User)T7449 Add $wgLogos->icon to ManageWiki
 DeclinedUnknown Object (User)T7429 Set wgMiserMode to true on all Miraheze wikis

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
RhinosF1 updated the task description. (Show Details)May 24 2021, 22:00
RhinosF1 updated the task description. (Show Details)
RhinosF1 updated the task description. (Show Details)May 24 2021, 22:02
RhinosF1 updated the task description. (Show Details)May 24 2021, 22:07
RhinosF1 updated the task description. (Show Details)May 24 2021, 22:11
RhinosF1 updated the task description. (Show Details)May 24 2021, 22:17
RhinosF1 updated the task description. (Show Details)
Unknown Object (User) added a comment.May 25 2021, 03:05

1.36.0 was released with https://gerrit.wikimedia.org/r/c/mediawiki/core/+/693987/ (not yet merged)

Unknown Object (User) updated the task description. (Show Details)May 25 2021, 03:50
Unknown Object (User) added a subtask: T7359: Test all extensions for 1.36.May 25 2021, 04:22
RhinosF1 updated the task description. (Show Details)May 25 2021, 07:32
RhinosF1 updated the task description. (Show Details)May 25 2021, 07:36
Redmin updated the task description. (Show Details)May 25 2021, 13:32
Redmin updated the task description. (Show Details)May 25 2021, 14:36
RhinosF1 updated the task description. (Show Details)May 25 2021, 14:45
RhinosF1 updated the task description. (Show Details)
RhinosF1 updated the task description. (Show Details)May 25 2021, 14:48
RhinosF1 updated the task description. (Show Details)May 25 2021, 14:52
RhinosF1 updated the task description. (Show Details)May 25 2021, 14:54
Paladox subscribed.May 25 2021, 15:22

I'm going to run https://github.com/wikimedia/mediawiki-extensions-CentralNotice/commit/33c729fcc749b47085ef18ff6364c718591a3df1#diff-3949da3a08da523b54e5d7f4ea2d9ef2ddbd7368f6e31cd052a48bfa744bb380 and https://github.com/wikimedia/mediawiki-extensions-CentralNotice/commit/33c729fcc749b47085ef18ff6364c718591a3df1#diff-b53edff06a759d8d1a2eaea0d54ed4e599b95a3040e606671bde03a2a6a4b087 on metawikis table.

It will be safe as it is adding columns and not removing existing data.

Paladox added a comment.May 25 2021, 15:39

I'm also going to apply https://github.com/wikimedia/mediawiki-extensions-DiscussionTools/blob/REL1_36/sql/mysql/discussiontools_subscription.sql to metawiki. It's a new table so is a noop and required by 1.36.

RhinosF1 updated the task description. (Show Details)May 25 2021, 17:37
RhinosF1 closed subtask T7358: Enable wgCheckUserEnableSpecialInvestigate as Resolved.May 25 2021, 18:27
RhinosF1 closed subtask T7360: Remove Variables as Declined.May 25 2021, 20:27
RhinosF1 updated the task description. (Show Details)May 25 2021, 21:05
Reception123 updated the task description. (Show Details)May 26 2021, 15:35
RhinosF1 updated the task description. (Show Details)May 26 2021, 18:47
RhinosF1 updated the task description. (Show Details)May 26 2021, 22:17
RhinosF1 updated the task description. (Show Details)
RhinosF1 added a comment.May 26 2021, 22:20

@Universal_Omega: Do you mind reviewing the graylog message I linked above? ~3000 like it.

Unknown Object (User) added a comment.May 26 2021, 22:24
In T7117#146914, @RhinosF1 wrote:

@Universal_Omega: Do you mind reviewing the graylog message I linked above? ~3000 like it.

I can... tomorrow.

RhinosF1 updated the task description. (Show Details)May 27 2021, 14:59
PiscesKazeMGR subscribed.May 27 2021, 15:16

Subscribing myself since this would affect my wikis '_'

RhinosF1 updated the task description. (Show Details)May 27 2021, 15:27
Unknown Object (User) added a comment.May 27 2021, 15:30

I'll update Comments if no one else does first, probably later today or tomorrow morning. But anyone else is welcome to if I don't get to it first.

RhinosF1 added a comment.May 27 2021, 15:33
In T7117#147042, @Universal_Omega wrote:

I'll update Comments if no one else does first, probably later today or tomorrow morning. But anyone else is welcome to if I don't get to it first.

The PR is there. I just don't have time to wait for rebuildi18n etc.

Unknown Object (User) added a comment.May 27 2021, 16:47
In T7117#146914, @RhinosF1 wrote:

@Universal_Omega: Do you mind reviewing the graylog message I linked above? ~3000 like it.

tracing:

Title::getLocalURL called from render action

from /srv/mediawiki/w/includes/Title.php(2315)
#0 /srv/mediawiki/w/includes/Title.php(2396): Title->getLocalURL(string)
#1 /srv/mediawiki/w/extensions/CentralAuth/includes/CentralAuthUtilityService.php(155): Title->getCanonicalURL()
#2 /srv/mediawiki/w/extensions/CentralAuth/includes/CentralAuthUtils.php(52): CentralAuthUtilityService->setP3P(FauxRequest)
#3 /srv/mediawiki/w/extensions/CentralAuth/includes/session/CentralAuthSessionProvider.php(310): CentralAuthUtils::setP3P(FauxRequest)
#4 /srv/mediawiki/w/includes/session/SessionBackend.php(736): CentralAuthSessionProvider->persistSession(MediaWiki\Session\SessionBackend, FauxRequest)
#5 /srv/mediawiki/w/includes/session/SessionBackend.php(644): MediaWiki\Session\SessionBackend->save()
#6 [internal function]: MediaWiki\Session\SessionBackend->MediaWiki\Session\{closure}()
#7 /srv/mediawiki/w/vendor/wikimedia/scoped-callback/src/ScopedCallback.php(96): call_user_func_array(Closure, array)
#8 /srv/mediawiki/w/vendor/wikimedia/scoped-callback/src/ScopedCallback.php(56): Wikimedia\ScopedCallback->__destruct()
#9 /srv/mediawiki/w/includes/session/SessionManager.php(888): Wikimedia\ScopedCallback::consume(NULL)
#10 /srv/mediawiki/w/includes/session/SessionManager.php(237): MediaWiki\Session\SessionManager->getSessionFromInfo(MediaWiki\Session\SessionInfo, FauxRequest)
#11 /srv/mediawiki/w/includes/session/PHPSessionHandler.php(218): MediaWiki\Session\SessionManager->getSessionById(string, boolean)
#12 [internal function]: MediaWiki\Session\PHPSessionHandler->read(string)
#13 /srv/mediawiki/w/extensions/TemplateStyles/vendor/wikimedia/at-ease/src/Wikimedia/AtEase/AtEase.php(74): session_start()
#14 /srv/mediawiki/w/includes/session/SessionBackend.php(819): Wikimedia\AtEase\AtEase::quietCall(string)
#15 /srv/mediawiki/w/includes/session/SessionBackend.php(739): MediaWiki\Session\SessionBackend->checkPHPSession()
#16 /srv/mediawiki/w/includes/session/SessionBackend.php(655): MediaWiki\Session\SessionBackend->save()
#17 /srv/mediawiki/w/includes/session/SessionBackend.php(629): MediaWiki\Session\SessionBackend->autosave()
#18 /srv/mediawiki/w/includes/session/Session.php(277): MediaWiki\Session\SessionBackend->renew()
#19 /srv/mediawiki/w/includes/Setup.php(775): MediaWiki\Session\Session->renew()
#20 /srv/mediawiki/w/includes/WebStart.php(87): require_once(string)
#21 /srv/mediawiki/w/index.php(44): require(string)
#22 {main}

see https://phabricator.wikimedia.org/T263581 as it seems to be what introduced the warning.

RhinosF1 added a comment.May 27 2021, 17:03

@Universal_Omega: can you raise upstream?

Unknown Object (User) updated the task description. (Show Details)May 27 2021, 20:35
RhinosF1 updated the task description. (Show Details)May 27 2021, 20:51
RhinosF1 updated the task description. (Show Details)
Unknown Object (User) added a comment.May 27 2021, 21:32

PortableInfobox gives fatal (same issue as https://github.com/lkucharczyk/mediawiki-PortableInfobox/issues/40) https://github.com/lkucharczyk/mediawiki-PortableInfobox/pull/41 should fix it.

RhinosF1 updated the task description. (Show Details)May 27 2021, 21:33
Unknown Object (User) updated the task description. (Show Details)May 27 2021, 22:21
Unknown Object (User) closed subtask T7253: Disable Modern Vector in 1.36 by default, Slow roll eventually as Resolved.May 27 2021, 22:54
MacFan4000 raised the priority of this task from Normal to High.May 28 2021, 01:00
MacFan4000 subscribed.

Raising priority given that we advertise that we run the latest version of MediaWiki and now 1.36 has been released.

Unknown Object (User) closed subtask T7383: Consider undeploying ModernSkylight skin as Resolved.Jun 2 2021, 09:31
Unknown Object (User) removed a subtask: T7156: Switch extension repositories / undeploy Validator.Jun 2 2021, 10:30
Unknown Object (User) renamed this task from Upgrade to 1.36 to Upgrade to MediaWiki 1.36.0.Jun 3 2021, 02:09
Unknown Object (User) added a project: Universal Omega.
Unknown Object (User) moved this task from Unsorted to Goals on the Universal Omega board.
Unknown Object (User) closed subtask T7389: Switch PortableInfobox repository as Declined.Jun 4 2021, 08:34
Unknown Object (User) updated the task description. (Show Details)Jun 4 2021, 18:33
Unknown Object (User) closed subtask T7357: Apply test3 drop default schema changes as Resolved.Jun 4 2021, 19:07
Unknown Object (User) updated the task description. (Show Details)Jun 4 2021, 19:35
Unknown Object (User) updated the task description. (Show Details)Jun 5 2021, 17:56
Unknown Object (User) closed subtask T7359: Test all extensions for 1.36 as Resolved.Jun 5 2021, 22:21
Unknown Object (User) added a comment.Jun 7 2021, 17:34

ApprovedRevs fixed; needs updated.
Found another issue with PageDisqus, https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PageDisqus/+/698351 will need merged and backported also, but not a blocker since it also effects 1.35 so doesn't matter about 1.36 much.

Unknown Object (User) updated the task description. (Show Details)Jun 7 2021, 17:35
Unknown Object (User) updated the task description. (Show Details)Jun 8 2021, 01:31
Unknown Object (User) added a comment.Jun 8 2021, 03:45

Found another ApprovedRevs blocker https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ApprovedRevs/+/698542/

Unknown Object (User) updated the task description. (Show Details)Jun 8 2021, 03:46
Unknown Object (User) updated the task description. (Show Details)Jun 8 2021, 04:56
Unknown Object (User) added a comment.Jun 8 2021, 05:00

ApprovedRevs works now after my patches were all merged and it updated.

Reception123 added a comment.Jun 11 2021, 06:12

The MediaWiki upgrade will be taking place Saturday at 19:00 UTC.

PiscesKazeMGR awarded a token.Jun 11 2021, 06:48
Redmin awarded a token.Jun 11 2021, 11:11
Bukkit subscribed.Jun 11 2021, 17:55
In T7117#148716, @Reception123 wrote:

The MediaWiki upgrade will be taking place Saturday at 19:00 UTC.

Amazing, I am hyped for the upgrade!

Unknown Object (User) updated the task description. (Show Details)Jun 12 2021, 18:28
RhinosF1 updated the task description. (Show Details)Jun 12 2021, 18:31
Redmin added a subtask: T7449: Add $wgLogos->icon to ManageWiki.Jun 12 2021, 18:32
Unknown Object (User) updated the task description. (Show Details)Jun 12 2021, 18:38
Unknown Object (User) updated the task description. (Show Details)Jun 12 2021, 18:54
Unknown Object (User) updated the task description. (Show Details)Jun 12 2021, 19:04
Restricted Repository Identity mentioned this in R9:ce4ac0726e98: Update config for 1.36 (#3824).Jun 12 2021, 19:45
Unknown Object (User) updated the task description. (Show Details)Jun 12 2021, 21:37
Unknown Object (User) closed this task as Resolved.Jun 12 2021, 22:10
Unknown Object (User) claimed this task.
Unknown Object (User) updated the task description. (Show Details)
Bukkit awarded a token.Jun 12 2021, 22:30
RhinosF1 added a parent task: T7450: Evaluate what happened during the 1.36 update.Jun 12 2021, 23:04
Unknown Object (User) closed subtask T7449: Add $wgLogos->icon to ManageWiki as Resolved.Jun 12 2021, 23:15
Unknown Object (User) added a subtask: T7429: Set wgMiserMode to true on all Miraheze wikis.
Unknown Object (User) added a subtask: T7000: Reconsider implementing Semantic MediaWiki.
Unknown Object (User) mentioned this in T4420: Introduce stats for IncidentReports.Jun 13 2021, 02:53
Unknown Object (User) closed subtask T7000: Reconsider implementing Semantic MediaWiki as Declined.Jun 13 2021, 06:50
Dmehus awarded a token.Jun 15 2021, 03:53
Unknown Object (User) closed subtask T7387: Consider enabling logging of CU data for logins as Resolved.Jun 19 2021, 03:17
Paladox unsubscribed.Jun 19 2021, 13:08
Unknown Object (User) closed subtask T7429: Set wgMiserMode to true on all Miraheze wikis as Declined.Jul 30 2021, 08:16
Excelsis reopened subtask T7000: Reconsider implementing Semantic MediaWiki as Open.Dec 8 2021, 16:52
Unknown Object (User) closed subtask T7000: Reconsider implementing Semantic MediaWiki as Declined.Dec 8 2021, 17:06
Unknown Object (User) reopened subtask T7000: Reconsider implementing Semantic MediaWiki as Open.Dec 10 2021, 18:34
Unknown Object (User) removed a subtask: T7000: Reconsider implementing Semantic MediaWiki.Dec 10 2021, 18:38