Page MenuHomeMiraheze
Create Task
Maniphest T7338

Investigate cause of wiki being created but not creation farmer log entry being created
Closed, DuplicatePublic
Actions

Description

Problem: toryismwiki was created, via this approval and re-approved here; however, no wiki creation farmer log entry was created. This has happened at least once before, in the past month or two. This is problematic for a couple reasons in order of importance:

  1. We use the wiki creation log entries to verify whether all approved wikis were successfully created; and,
  2. We use the wiki creation log entries to publish wiki creators' wiki creation stats, as seen in the raw wiki creation stats

Thus, I ask the MediaWiki Engineering team to investigate the cause of this bug / production error, as it has happened more than once

Thank you

Related Objects

Event Timeline

Dmehus triaged this task as High priority.May 21 2021, 23:38
Dmehus created this task.
Herald added a project: Universal Omega. · View Herald TranscriptMay 21 2021, 23:38
Herald added subscribers: Unknown Object (User), RhinosF1, Reception123, NDKilla. · View Herald Transcript
Dmehus moved this task from Unsorted to Short Term on the Universal Omega board.May 21 2021, 23:39
Dmehus moved this task from Backlog to Deployed Extension Bugs on the Extensions board.
Dmehus moved this task from Backlog to Short Term on the MediaWiki (SRE) board.
Dmehus updated the task description. (Show Details)
Dmehus mentioned this in T7339: Create local account for EagleBoss on toryismcanadawiki.May 21 2021, 23:57
Unknown Object (User) lowered the priority of this task from High to Normal.May 22 2021, 02:48

This is the same issue that was the reason the user did not auto get the correct rights, the main page was not populated, the "Wiki created." message was not given by CreateWiki extension in RequestWikiQueue.

It's the exact same issue as the issue we've had for a very long time, and fairly rare that it happens. Does not need to be High priority, and possibly could be low priority, but I am triaging as normal for now.

Reception123 removed a project: Production Error.May 22 2021, 05:49

Production Error should only be used for tasks "which have an error log or stack trace attached from Miraheze Production"

Redmin edited projects, added CreateWiki; removed Extensions.May 22 2021, 15:55
Herald added a subscriber: Void. · View Herald TranscriptMay 22 2021, 15:55
Unknown Object (User) moved this task from Backlog to Bugs on the CreateWiki board.May 22 2021, 17:22
Void renamed this task from Investigate cause of wiki being created by not creation farmer log entry being created to Investigate cause of wiki being created but not creation farmer log entry being created.May 22 2021, 18:34
Unknown Object (User) merged a task: T7373: Investigate cause of redis server error (socket error on read socket) when CreateWiki Extension creates a wiki.May 27 2021, 02:56
Unknown Object (User) added subscribers: Paladox, • WikiJS.
Dmehus mentioned this in T7373: Investigate cause of redis server error (socket error on read socket) when CreateWiki Extension creates a wiki.May 27 2021, 05:17
Paladox unsubscribed.Jun 15 2021, 21:34
Reception123 closed this task as Declined.Jun 20 2021, 16:50
Reception123 claimed this task.

The reason why the log wasn't created was because something went wrong with the particular wiki creation, and the log entry is the last thing that's executed. Unfortunately, we can't reproduce that error or investigate it really especially since a month has passed. CreateWiki errors can happen for all kinds of reasons but they are very rare in nature but are bound to happen every once in a while because of different factors. For that reason this task should be declined as there is nothing that can be realistically done to investigate that particular issue (which isn't the log not creating in itself)

Dmehus reopened this task as Open.Jun 20 2021, 17:47

@Reception123, this is reproducable as it has happened multiple times now. I suspect it's something to do with the way in which the updated CreateWiki extension "talks" to the now locally forked jobrunner/redis server process. As you told me privately this would definitely be looked into with a view to resolving, if you have no objections, I'd rather prefer to reopen this task, and lower its priority to low as it's a bit niche. I get that you're trying to reduce the task backlog, but as this is happening with increasing frequency and since the wiki creator statistics are based on created wiki farmer log entries, it does need to be resolved as it never happened before (i.e., late last year).

Dmehus lowered the priority of this task from Normal to Low.Jun 20 2021, 17:48

Per this

RhinosF1 closed this task as Declined.Jun 20 2021, 17:49

T7373: Investigate cause of redis server error (socket error on read socket) when CreateWiki Extension creates a wiki is open and can deal with the redis errors.

As Reception said, if it didn't create successfully then it won't log.

We can manually create log entries on the rare occasion it fails but the question on this task is why isn't it logging it created. The answer to that is because it never created fully.

Dmehus added a comment.Jun 20 2021, 17:51

Reopening per private dialogue with Reception123 on IRC. Please leave this for him to close. Thanks!

Dmehus reopened this task as Open.Jun 20 2021, 17:51
Void added a comment.Jun 20 2021, 18:17

IMO this task is still valid, but not for the focus it has. I don't particularly care about the wiki creator statistics being accurate. But I do care about the implication that a failure in the wiki creation process leaves the wiki in an incomplete status. IMO the proper solution here is to have a wiki creation failure clear the incomplete wiki and report the issue somehow.

Dmehus added a comment.Jun 28 2021, 02:54
In T7338#150494, @Void wrote:

IMO this task is still valid, but not for the focus it has. I don't particularly care about the wiki creator statistics being accurate. But I do care about the implication that a failure in the wiki creation process leaves the wiki in an incomplete status. IMO the proper solution here is to have a wiki creation failure clear the incomplete wiki and report the issue somehow.

Yeah, I'd agree with that. :)

In any case, I actually came here to report a further related problem to this. In my recreating harnicawiki, something strange happened. The wiki was recreated, Main Page was created, and the requestor was given bureaucrat and sysop rights, but the strange thing is there was no CentralAuth automatic account creation log entry in the Special:Log/newusers log.

Case in point:

Ordinarily, with every wiki created, there is a log entry for MediaWiki default (the system user) and the wiki requestor's account being automatically locally attached as part of the wiki creation job.

Herald added a subscriber: Bukkit. · View Herald TranscriptJun 28 2021, 02:54
Dmehus mentioned this in T7549: Persistent cannot connect to database server (db11.miraheze.org) on metawiki.Jun 28 2021, 03:26
Dmehus added a comment.Jul 3 2021, 15:35

It's happened again in this wiki request. No farmer log creation log entry created, but the user's bureaucrat and sysop rights were added. Main Page was created, but still we have Exception experienced creating the wiki. Error is: Redis server error: socket error on read socket. I agree with @Void above that while the lack of a farmer log entry is relatively minor (we should be able to manually add these via the database as they occur), the fact that the CreateWiki job is not completing with full success is problematic. I suspect there's likely a communication problem or conflict of some sort between the way the CreateWiki extension/MediaWiki "talk" to the Redis server. Not sure what that problem is, but this should definitely be investigated thoroughly, tough as a nut to crack as it may be...

RhinosF1 added a comment.Jul 3 2021, 17:06

I had Redis issues on an import last night

Reception123 added a comment.Jul 12 2021, 06:06

Error with https://meta.miraheze.org/wiki/Special:RequestWikiQueue/19224

Void closed this task as a duplicate of T7626: redis-server is occasionally killed for OOM.Jul 17 2021, 01:05
Unknown Object (User) mentioned this in T7626: redis-server is occasionally killed for OOM.Jul 19 2021, 18:05