Page MenuHomeMiraheze

Images not updating to their new version
Closed, ResolvedPublic

Description

I got some images that despite being updated a few days ago, still won't appear properly. Instead the old version displays.

These being

https://idleon.info/wiki/File:Goblin_Gorfest_Totem.gif
https://idleon.info/wiki/File:Acorn_Assault_Totem.gif
and
https://idleon.info/wiki/File:Frigid_Soul.png (though this one is a bit more recent)

Could you please look into this? Far from the first time this has happened and it drives me nuts every time. :(

Event Timeline

Bukkit triaged this task as Normal priority.Jun 11 2021, 17:50
Bukkit added projects: MediaWiki, MediaWiki (SRE).

It's definitely something funky on the cache proxy, as they display the updated version for me (edit: it displays updated for some, but not others). I'm not certain if there's anything we could do to make sure these don't get stuck like this regularly. We should look for a long term solution, IMO.

Unknown Object (User) moved this task from Backlog to Short Term on the MediaWiki (SRE) board.Jun 15 2021, 17:05
Unknown Object (User) closed this task as Invalid.Jun 16 2021, 06:45
Unknown Object (User) claimed this task.

All Varnish cache expires within a week. After that it becomes definitely local cache or client side not server side. I talked with paladox about this awhile ago and was given a we can't do anything about this further answer. Therefore closing as invalid since nothing we can do and they would update eventually. If someone comes up with a solution feel free to reopen though.

Void claimed this task.

On uploads and certain other actions, mediawiki should be sending a purge request to the CDNs (Varnish) that should clear the cache. The fact that this isn't happening for us would appear to be a bug.

Unknown Object (User) moved this task from Unsorted to Short Term on the Universal Omega board.Jun 16 2021, 16:44
In T7441#149792, @Void wrote:

On uploads and certain other actions, mediawiki should be sending a purge request to the CDNs (Varnish) that should clear the cache. The fact that this isn't happening for us would appear to be a bug.

That makes sense then. Thank you for looking at this!

Yeah, I've confirmed that we have some sort of issue with MediaWiki sending PURGE requests to static.miraheze.org:

Error fetching URL "https://static.miraheze.org/test3wiki/7/7f/Testing.png": (curl error: 56) Failure when receiving data from the peer

I've confirmed in graylog that this issue pops up for upload actions across multiple wikis, and can generate it using purgeList.php.

For another example:

https://30xx.miraheze.org/wiki/Juiced_Reserves & https://30xx.miraheze.org/wiki/File:Juiced_Reserves.png (and for clarification, https://30xx.miraheze.org/wiki/File:Juiced_Reserves_0.22.2.png)

For context on what I'm doing: Moving the old Juiced_Reserves.png to Juiced_Reserves_0.22.2.png (so I can use the old image in the history section), and creating a new Juiced_Reserves.png with the new sprite from 0.23. It appears like the old 0.22.2 version, but I know that the 0.23 version is the one that's uploaded. I'm basically just pretending it looks like it should right now, because I know serverside the images will update within a few days.

This bug has been confusing some editors of the 30XX Wiki, along with just making it pretty awkward to update images in general.

The cause for this is the same as https://phabricator.wikimedia.org/T285504, however, we've already fixed that issue for wiki pages. Instead, the problem we are having is caused due to the image URL being set as https://static.miraheze.org/whatever. We need to tell the file repo, (or perhaps make some other change) to strip https from this url and replace it with http so the purge request can be properly proxied to the server.

Resolved through local hack, for upstream task, see T285504.