Page MenuHomeMiraheze

CommentStreams extension not functioning properly with Moderation extension
Closed, DeclinedPublic

Description

I am experiencing a problem on lolpasta.miraheze.org

I am currently using the Moderation extension to help prevent spam and I noticed that regular users can't submit comments with the CommentStreams extension, when they do a warning message about API usage pops up. They can submit comments only if I give them the automoderated user right.

This is the warning message:

"See https://lolpasta.miraheze.org/w/api.php for API usage. Subscribe to the mediawiki-api-announce mailing list at <https://lists.wikimedia.org/mailman/listinfo/mediawiki-api-announce> for notice of API deprecations and breaking changes."

What happens precisely is that the regular users get this message when they try to post comments, the comment still gets to the Special:Moderation page but doesn't show up in the page even if approved. What's odd is that the "non-existing" comment stream shows up in the recent changes while comments successfully posted don't.

As I said Automoderated users, and Admins too, can post without problems.

Event Timeline

Currently these 2 extensions are not compatible. This can only be fixed in Extension:CommentStreams (can't be workarounded on Moderation side).
The cause is that CommentStreamsStore::updateComment() in CommentStreamsStore.php treats "edit was sent to moderation" as an error (instead of "saved successfully") and panics "we couldn't save the comment".

Unknown Object (User) triaged this task as Normal priority.Jun 26 2021, 03:21
Unknown Object (User) added projects: Extensions, MediaWiki (SRE).
Unknown Object (User) moved this task from Backlog to Deployed Extension Bugs on the Extensions board.Jun 26 2021, 03:21
Unknown Object (User) moved this task from Backlog to Short Term on the MediaWiki (SRE) board.
Unknown Object (User) moved this task from Unsorted to Short Term on the Universal Omega board.
Unknown Object (User) closed this task as Declined.Jun 26 2021, 03:26
Unknown Object (User) claimed this task.

Conflict added to ManageWiki with https://github.com/miraheze/mw-config/pull/3983. Unfortunately not much more we can do in that case so closing task unfortunately.