Page MenuHomeMiraheze
Create Task
Maniphest T7695

Loops does not properly limit loop count
Closed, ResolvedPublic
Actions

Description

Extension:Loops has a loop counter that should prevent a loop from executing more than 100 times. However, simply creating a page with:
{{#while:|true|}}
causes it to loop indefinitely, which hangs php-fpm and consumes all available resources.

Related Objects

Event Timeline

Void created this task.Jul 26 2021, 05:53
Herald added a project: Universal Omega. · View Herald TranscriptJul 26 2021, 05:53
Herald added subscribers: Universal_Omega, RhinosF1, Reception123. · View Herald Transcript
Void added a comment.Jul 26 2021, 05:53

Most likely cause of T7693

Void added a comment.EditedJul 26 2021, 06:00

I've disabled Loops on all wikis. Leaving as disabled this way in order to be able to test on test3.

RhinosF1 added a comment.Jul 26 2021, 06:47

Has this been reported upstream?

Void added a comment.EditedJul 26 2021, 17:32
In T7695#154722, @RhinosF1 wrote:

Has this been reported upstream?

Not yet, this was 2am my time, all I could do last night was disable for performance.

EDIT: I see there's https://phabricator.wikimedia.org/T287347

RhinosF1 added a comment.Jul 26 2021, 18:44

https://phabricator.wikimedia.org/T287347

Void claimed this task.Jul 28 2021, 20:40
Void lowered the priority of this task from High to Low.
Void changed the visibility from "Custom Policy" to "Public (No Login Required)".
Void changed the edit policy from "Custom Policy" to "All Users".
Herald added a subscriber: NDKilla. · View Herald TranscriptJul 28 2021, 20:40
Void closed this task as Resolved.Jul 28 2021, 20:50