Page MenuHomeMiraheze

Loops does not properly limit loop count
Closed, ResolvedPublic

Description

Extension:Loops has a loop counter that should prevent a loop from executing more than 100 times. However, simply creating a page with:
{{#while:|true|}}
causes it to loop indefinitely, which hangs php-fpm and consumes all available resources.

Event Timeline

I've disabled Loops on all wikis. Leaving as disabled this way in order to be able to test on test3.

Has this been reported upstream?

Has this been reported upstream?

Not yet, this was 2am my time, all I could do last night was disable for performance.

EDIT: I see there's https://phabricator.wikimedia.org/T287347

Void lowered the priority of this task from High to Low.
Void changed the visibility from "Custom Policy" to "Public (No Login Required)".
Void changed the edit policy from "Custom Policy" to "All Users".