Page MenuHomeMiraheze

About the malfunction of the abuse filter
Closed, InvalidPublic

Description

T7643
First of all, I apologize for the delay in replying to the previous task.

See the previous task for the problem you are having.

According to my research, the problem started after the update to MediaWiki (1.36) was performed on June 12, 2021 at 19:00 (UTC).

If you compare https://shiropedia.miraheze.org/wiki/%E7%89%B9%E5%88%A5:ManageWiki/settings and https://newusopedia.miraheze.org/wiki/%E7%89%B9%E5%88%A5:ManageWiki/settings, you can see that they have the same settings.

Also, if you compare https://shiropedia.miraheze.org/wiki/%E7%89%B9%E5%88%A5:%E4%B8%8D%E6%AD%A3%E5%88%A9%E7%94%A8%E3%83%95%E3%82%A3%E3%83%AB%E3%82%BF%E3%83%BC/10 and https://newusopedia.miraheze.org/wiki/%E7%89%B9%E5%88%A5:%E4%B8%8D%E6%AD%A3%E5%88%A9%E7%94%A8%E3%83%95%E3%82%A3%E3%83%AB%E3%82%BF%E3%83%BC/164, you can see that the scripts are the same.

After some trial and error, the latter works differently from the former, but if you look at the filter history, you can see that the settings of the two filters are exactly the same.

The two originally blocked Spam in exactly the same way, but only the Usopedia filter does not block Spam properly.

I would like you to fix this issue as soon as possible so that the latter filter can resume blocking like the former filter.

Event Timeline

J-Josyu triaged this task as High priority.Aug 10 2021, 10:46
J-Josyu created this task.

We at Usopedia are struggling with so many spam registrations because of this issue. Therefore, the importance is set to High and I want you to corrected as soon as possible.

Since it was machine translated, it may be difficult to understand some meanings. I'm sorry.

To summarize this problem in one word

  1. There are two filters in the same script
  1. The ManageWiki settings for spam filters are the same for the two wikis.
  1. Immediately after the update, one of the filters (Usopedia) no longer blocks spam properly.
  1. After updating, other filters (Shiropedia) will successfully block spam.
  1. Please correct this and restore it to its original state.
Reception123 lowered the priority of this task from High to Normal.Aug 10 2021, 11:56

Of the last 2 actions, this filter has matched 2 (100%). On average, its run time is 0.49 ms, and it consumes 3 conditions of the condition limit.

On Usopedia so I'm not exactly sure how it isn't working? Also, the "actions" on the 2 filters are not the same. So it's possible it's matching them just not actioning them.

Although if we're hitting 100% of edits it will throttle

Since it is a Japanese-speaking wiki, it is a filter that blocks user names composed of English and numbers when creating an account. This is the 164th filter in Usopedia. Originally, users who fit the filter syntax were blocked, but because of a malfunction, they no longer block, so we are changing the action from blocking to disallowing now. There is no doubt that it works according to the syntax, but even if the action block is checked, the filter will not block it.

Looking at the change history of filter 164, we can see that this was originally the same action as filter 10 in Shiropedia. Action changes are provisional. It's strange that the same filter that blocks successfully on one wiki doesn't block on the other wiki.

Looking at the change history of filter 164, we can see that this was originally the same action as filter 10 in Shiropedia. Action changes are provisional. It's strange that the same filter that blocks successfully on one wiki doesn't block on the other wiki.

I am also unable to reproduce this on my own wiki with everything exactly the same as the one that works.

Please make sure everything is the same on both wikis filters, including actions, if only to rule out the difference being the cause, it just makes debugging easier also. But the filter is matching stuff it just isn't blocking so the action for that is not working is all.

Backtracking through the filter history, I can see hits with Action taken None when it was set as block only.

Currently I see it warning & tagging instead but that's what you've selected. As Universal_Omega said, can you try leaving it as exactly equal to the filter on shiropedia. My only thought is could it have been throttled if it was hitting 100% from 2.

Given we just raised the throttle, that might have eased it.

It's pretty hard though to tell now whether it was in the past.

Universal_Omega claimed this task.

Please reopen this task after trying what I mentioned above. It does seem unreproducable by myself so I'm not sure what else it could be. Thanks!

Usopedia's filter 164 and Shiropedia's filter 10 have been changed to exactly the same settings, including actions. As mentioned earlier, accounts that fit the syntax are also not blocked.
This can also be seen in the fact that the subfilter 179 (same setting as 164, now stopped to match Shiropedia's behavior) created when the 164th filter stopped working was also unblocked.

Was it a problem that there were competing filters?

Usopedia's filter 164 and Shiropedia's filter 10 have been changed to exactly the same settings, including actions. As mentioned earlier, accounts that fit the syntax are also not blocked.
This can also be seen in the fact that the subfilter 179 (same setting as 164, now stopped to match Shiropedia's behavior) created when the 164th filter stopped working was also unblocked.

Was it a problem that there were competing filters?

Possibly an issue with competing filters. If the exact same setting, action, etc, tested the exact same way on the exact same account and one is not working, then I have no ideas.

Here is evidence that the sub-filter 179 does not block Spam accounts even if they detect them.

https://newusopedia.miraheze.org/wiki/%E7%89%B9%E5%88%A5:%E4%B8%8D%E6%AD%A3%E5%88%A9%E7%94%A8%E8%A8%98%E9%8C%B2

↑for example
https://newusopedia.miraheze.org/wiki/%E7%89%B9%E5%88%A5:%E4%B8%8D%E6%AD%A3%E5%88%A9%E7%94%A8%E8%A8%98%E9%8C%B2/12075

Look at this log. result say 「Action: None」! I setted this filter to block spam

I stoped filter179.

But at first, we had filter164 only.

then filter 164 not work

I think competing filters doesn't cause a problem

Ok, I do think I know the issue now. The abuse filter user (不正利用フィルター) is in the administrator group, however the administrator group does not have the rights to block users, therefore it is not working.

Correction, from https://newusopedia.miraheze.org/wiki/%E7%89%B9%E5%88%A5:%E5%88%A9%E7%94%A8%E8%80%85%E3%82%B0%E3%83%AB%E3%83%BC%E3%83%97%E6%A8%A9%E9%99%90 it seems like there are 2 administrator user groups. One does not the other does. I am unsure if this is the issue now.

I think the administrator group have the rights to block users.

Please check https://newusopedia.miraheze.org/wiki/%E7%89%B9%E5%88%A5:%E5%88%A9%E7%94%A8%E8%80%85%E3%82%B0%E3%83%AB%E3%83%BC%E3%83%97%E6%A8%A9%E9%99%90 「管理者」have the rights to block users.

不正利用フィルターis menber of 「管理者」

so maybe you wrong

Also note this will not block account autocreations so if that is your issue then it wont work (anyone can create an account on another wiki and visit your wiki and it wont block) this is done intentionally also. But your filter is not even setup to block autocreateaccount action but thought I would mention that.

Can you give an example of an account that should be blocked but was not, and is not currently blocked by someone else on the wiki?

It is difficult because we blocked spam that filter didn't block

Since the AbuseFilter was changed to match exactly there have been zero actions for it to attempt to block, once it tries and if it fails again please let me know.

Closing again per the above. If you encounter the issue once again do re-open this task again. Only closing as invalid as if it was fixed by you changing it to match, then it is not something for us to handle. Thank you for your patience here.

I noticed it still doesn't work. Apologies for the issue. I'll try asking around to see if we can't resolve the issue.

Due to the delay in response, the number of spam account registrations is increasing rapidly, so enable the filter once to block all spam accounts. Please let me know if you have any problems

I just did some testing with one of the names that supposedly wasn't blocked and got a warning twice & then blocked.

I hit many many abuse filters though.

Is there a chance that you have multiple filters conflicting?

Previously there were multiple anti-spam filters, but I disabled them when making this request. Only 164 is running as an anti-spam filter, but other anti-LTA filters may have been applied.

Please review the Anti LTA filters too. You have multiple filters matching the same thing.

I'm sorry, there are about 170 filters, so I can't check all of them. And, as I've said many times, Filter 164 used to work. I don't think competition is a problem

Unfortunately, we can't see an issue though. The filter is able to block fine.

I don't see it being throttled but the one thing I noticed is how long account creation takes and the fact I triggered so many filters. Despite it saying it took no action, it blocked me so it's impossible to know which filter did.

I missed the notification, but received a notification that the blocking and prohibition action for filter 164 was not performed.

That notification say "Abuse filter 164 you recently edited was throttled"

When I clicked on the notification, I went to the edit screen of filter 164 and a warning was written.

Warning: This filter was automatically flagged as harmful. As a safety measure, the following actions are not performed (block). Please check and optimize the conditions for removing this restriction.

This is the warning displayed.

And the "optimize" part was linked to page https://mediawiki.org/wiki/Extension:AbuseFilter/Conditions .

I don't no what this mean

That's very important. I never saw it come up. It essentially means there's too much spam for abuse filter to be suitable.

You need to try something like spam blacklist.

Unfortunately, we can't see an issue though. The filter is able to block fine.

I don't see it being throttled but the one thing I noticed is how long account creation takes and the fact I triggered so many filters. Despite it saying it took no action, it blocked me so it's impossible to know which filter did.

As I've said many times, the filter was blocking spam, even though it was previously in conflict.

Do not exit without resolving the issue.

You've just said it was throttled. That's why.

You can't use abuse filter as it's not suitable for that level of spam.

Please consider Spam blacklist.

That's very important. I never saw it come up. It essentially means there's too much spam for abuse filter to be suitable.

You need to try something like spam blacklist.

OK Please tell me how to do it.

I looked at our config. I will see if we can allow local title blacklists.

You need to ask on SN for now for a steward to move your regex to https://meta.miraheze.org/wiki/Title_blacklist if they believe it appropiate.