Page MenuHomeMiraheze
Create Task
Maniphest T7945

[GlobalNewFiles] Create better CI for MediaWiki standards and security
Closed, ResolvedPublic
Actions

Description

A better CI should be built for GlobalNewFiles to maintain better code quality by using the MediaWiki standards.

Phan (with phan-taint-check-plugin) should be used to check for certain security vulnerabilities.

It should be created so that GitHub actions will automatically commit minor formatting fixes, that the CI can automatically detect and fix. Thus should have no negative effect, since it wouldn't automatically commit anything but formatting issues.

I am working on doing this.

  • PHPCS
  • Phan

https://github.com/miraheze/GlobalNewFiles/pull/19

Related Objects

Event Timeline

Universal_Omega triaged this task as Low priority.Sep 2 2021, 17:51
Universal_Omega created this task.
Herald added projects: Universal Omega, MediaWiki (SRE). · View Herald TranscriptSep 2 2021, 17:51
Herald added a subscriber: RhinosF1. · View Herald Transcript
Universal_Omega mentioned this in T7939: Add better CI for MediaWiki standards.Sep 2 2021, 18:00
Universal_Omega moved this task from Backlog to Maintenance on the GlobalNewFiles board.Sep 2 2021, 18:02
Universal_Omega moved this task from Backlog to Short Term on the MediaWiki (SRE) board.
Universal_Omega moved this task from Unsorted to Goals on the Universal Omega board.
Universal_Omega added a comment.Sep 2 2021, 21:22

Just to note, while it's not a huge deal for GlobalNewFiles since it requires CreateWiki, which is not much used externally, Phan did catch an error which would've caused the updater to fatal.

Universal_Omega closed this task as Resolved.Sep 4 2021, 00:05
Universal_Omega updated the task description. (Show Details)