Page MenuHomeMiraheze

Test DiscordRCFeed on publictestwiki
Closed, DeclinedPublic

Description

Hi, I am very new to the Miraheze community and a maintainer of an extension, DiscordRCFeed.

DiscordRCFeed is designed to replace DiscordNotifications and has more simple but flexible configurations.
The perspective of a maintainer, its codebase is simpler because it uses features of the core of MediaWiki (RCFeedEngine and RCFeedFormatter) as possible and includes unit tests and code coverage, etc.
For further information of DiscordRCFeed, please visit the extension page on Mediawiki.org or the homepage on Github.

Anyway, I hope to advertise the extension to people and encourage them to use it, but now, it is only used on one wiki according to WikiApiary.
Could I request to test this extension on publictestwiki?

Feel free to decline this ticket If it is not a suitable one.
Thank you.

Event Timeline

I think the best approach would be to phase this out slowly, as a consul, you have a +1 from me on testwiki to test this. We should probably notify the community though. @Agent_Isai: can you handle? This is a good candidate for the experimental groups.

RhinosF1 moved this task from Backlog to Short Term on the MediaWiki (SRE) board.

Subject to security review too

I recommend should this be approved, and works similar to DiscordNotifications in terms of functionality, that we disable DiscordNotifications, and enable this extension globally instead.

This is not a suitable replacement due to the differences in configuration. It is not possible to migrate existing webhooks to use for $wgRCFeeds, nor is it even possible to use any configuration for this via ManageWiki as wgRCFeeds is impossible to even add to ManageWiki regardless. I'm not saying I won't review and approve it, but as I replacement we can not do.

Actually I don't even think installing this is possible if the config is like this, and it can't become a replacement, as it seems like it would directly conflict with DiscordNotifications, which is global.

This is not a suitable replacement due to the differences in configuration.

I agree, I didn't intent replacement should be done globally.

It is not possible to migrate existing webhooks to use for $wgRCFeeds, nor is it even possible to use any configuration for this via ManageWiki as wgRCFeeds is impossible to even add to ManageWiki regardless.

Is it a sort of a limitation of ManageWiki itself? How do you think the possibility to make it possible by modifying DiscordRCFeed? I'm willing to do it if there is.

Actually I don't even think installing this is possible if the config is like this, and it can't become a replacement, as it seems like it would directly conflict with DiscordNotifications, which is global.

Could I request you more details? DiscordRCFeed uses its own namespace and should not conflict with DiscordNotifications. Also, I just have tested it and both extensions work fine on one MediaWiki instance at the same time. Is the problem you mentioned Miraheze-specific?

Is it a sort of a limitation of ManageWiki itself? How do you think the possibility to make it possible by modifying DiscordRCFeed? I'm willing to do it if there is.

The only way would be to make the configs be the same or similar to DiscordNotifications, otherwise adding webhooks can't be done, except through PrivateSettings.php, which I'm highly against doing that again (as we once did for DiscordNotifications before I added support for private configs in ManageWiki) as it limits access for who can do that.

Could I request you more details? DiscordRCFeed uses its own namespace and should not conflict with DiscordNotifications. Also, I just have tested it and both extensions work fine on one MediaWiki instance at the same time. Is the problem you mentioned Miraheze-specific?

Well I guess it is possible that it could work, but DiscordNotifications is enabled globally with a global webhook for the Miraheze server, so I just assumed incompatibility.

Actually doing wgRCFeeds even in PrivateSettings.php might not work, as due to it being a core essential config for other portions of our configuration as well.

It may be possible to come up with a workaround though, through some config, creating $wmgDiscordRCFeedWebhook for ManageWiki, and assigning that to the config for $wgRCFeeds. It's not ideal but it will work, as we've done something similar in the past. However we don't usually enable extensions per-wiki so if we did install it, it wouldn't be enabled globally, but would be available through Special:ManageWiki/extensions on all wikis. Therefore I do have to ask, what are the advantages of using functionality of this extension vs DiscordNotifications, as I don't want to install an extension with not much of a use here either. I agree your version is much more modern and nicer code, but again not a replacement, so I don't want to install an extension which only provides duplicate functionality either.

I would like to note, as @RhinosF1 mentioned above "This is a good candidate for the experimental groups.", I am very highly against this course of action. I do not believe any extensions should be limited to any particular group of wikis, and should always be available from ManageWiki (even if restricted), or global. As ever since I've been here one of my goals has been improving ManageWiki and adding more options, and improve noticeablity. Doing such action directly contradicts that.

Then, this task will be closed as declined? I'm ok with the result and thank you very much for reviewing the extension and spending your time!

Then, this task will be closed as declined? I'm ok with the result and thank you very much for reviewing the extension and spending your time!

I'm willing to approve it if there is a legitimate use-case (for any wikis), that DiscordNotifications can't accomplish. Otherwise I think that'd be best, apologies for any inconvenience caused.

Although I don't know when it occurs, I expect some wiki to request DiscordRCFeed in the future as it could be a solution to some feature requests, For instance, Multiple webhooks, Different namespaces with different webhooks, or Add posibillity to disable notifications about translations. Especially, It is hard to implement the second one in an elegant way on DiscordNotifications due to the architecture.
But thinking of ManageWiki, the fact that those features are only accomplished by editing a 3-dimensional array would be an obstacle, too.

For the record I intend to fork DiscordNotifications (not advertise the fork at all) itself to add minimal (bugfix)-support to it as because of issues with 1.37 so per namespace webhooks is something that could be at least considered with something that can still be supported by Special:ManageWiki/namespaces. Tbh, I likely wouldn't put to much effort into it for features though. Multiple webhooks for all pages is supported by DiscordNotifications, but not by our setup with ManageWiki.

Apologies for the inconvenience but I am going to go ahead an mark this as declined per the above conversation.