Page MenuHomeMiraheze
Create Task
Maniphest T8743

Upgrade to MediaWiki 1.38.1
Closed, ResolvedPublic
Actions

Description

This is obviously not close yet but mostly opening so far so we don't forget that ALTER TABLE searchindex MODIFY COLUMN si_title MEDIUMTEXT; has been run on allthetropeswiki, bandolerismowiki and empiredarsoiswiki and that that may need to be looked at before schema changes with 1.38

Unfixed blockers:

Prep Work

  • Get list of SQLs (CORE - P454)
  • Set central auth hidden level migration (patch-gu_hidden_normalize.sql) (DONE sql, set migration to OLD)
  • .....

Upgrade process

Upgrade START date/time: 15/06/2022 - 20:00 UTC

(approx) upgrade END date/time: 15/06/2022 - 00:00 UTC

Steps

  1. [17:01] mwupgradetool
  2. (WHEN PROMPTED) Merge Puppet PR to flip branch
  3. (WHEN PROMPTED) - read only PR -
  4. follow script
  5. Run SQL changes [@Someone]

Post upgrade work

  • refresh image meta data

SQL/Maintenance scripts:

P454

Availability of SRE during upgrade
@Agent_Isai will be available from 13:00 UTC to 05:00 UTC
@RhinosF1 will be available from 20:00 UTC to 22:00 UTC at the latest (more likely between 21:00 & 21:30 UTC leaving)
@Reception123 will be available from 20:00 to 21:00 UTC + next morning
@Universal_Omega will be available from 20:00 to 22:00 UTC
@Paladox will be available from 20:00 to 22:00 UTC
@MacFan4000 will be available from 20:00 to 03:00 UTC (intermittent during the earlier hours)
@John will be available from

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
RhinosF1 updated the task description. (Show Details)Feb 7 2022, 21:14
RhinosF1 updated the task description. (Show Details)Feb 7 2022, 21:16
RhinosF1 updated the task description. (Show Details)Feb 7 2022, 21:19
Universal_Omega removed a subscriber: Universal_Omega.Feb 12 2022, 07:26
RhinosF1 added a subtask: T8369: explicitly selected deploys should not imply canary.Feb 18 2022, 21:47
RhinosF1 added a subtask: T7578: Consider removal of Extension:HideSection.
RhinosF1 reopened subtask T7578: Consider removal of Extension:HideSection as Open.
RhinosF1 added a subtask: T8671: Undeploy UserMerge.Feb 18 2022, 21:49
RhinosF1 added a subtask: T8784: CI on MirahezeMagic is broken for 1.38.Feb 18 2022, 22:01
Reception123 closed subtask T8784: CI on MirahezeMagic is broken for 1.38 as Resolved.Feb 19 2022, 18:02
Reception123 reopened subtask T8784: CI on MirahezeMagic is broken for 1.38 as Open.Feb 19 2022, 18:04
RhinosF1 updated the task description. (Show Details)Feb 20 2022, 21:51
RhinosF1 closed subtask T8671: Undeploy UserMerge as Resolved.
RhinosF1 added a subscriber: Universal_Omega.
Universal_Omega updated the task description. (Show Details)Feb 20 2022, 21:55

Mathoid doesn't need updated everytime. Only last time because it was broken.

Universal_Omega removed a subscriber: Universal_Omega.Feb 20 2022, 21:57
Ugochimobi added a subscriber: Ugochimobi.Feb 20 2022, 22:39
RhinosF1 changed the task status from Stalled to Open.Feb 21 2022, 12:15
RhinosF1 raised the priority of this task from Low to Normal.

This is being worked on.

RhinosF1 updated the task description. (Show Details)Feb 21 2022, 12:16
RhinosF1 closed subtask T8369: explicitly selected deploys should not imply canary as Resolved.
RhinosF1 added a subscriber: Universal_Omega.
RhinosF1 closed subtask T8784: CI on MirahezeMagic is broken for 1.38 as Resolved.Feb 23 2022, 10:26
RhinosF1 closed subtask T8787: Sort out the upgrade branching commands as Resolved.
RhinosF1 updated the task description. (Show Details)Feb 23 2022, 11:42
RhinosF1 updated the task description. (Show Details)Feb 23 2022, 11:45
RhinosF1 updated the task description. (Show Details)Feb 23 2022, 11:51
RhinosF1 updated the task description. (Show Details)Feb 23 2022, 12:11
Reception123 updated the task description. (Show Details)Mar 1 2022, 07:06
Universal_Omega removed a subscriber: Universal_Omega.Mar 1 2022, 10:02
Universal_Omega closed subtask T7578: Consider removal of Extension:HideSection as Declined.Mar 3 2022, 07:25
Universal_Omega added a subtask: T8897: Remove MagicNumberedHeadings.Mar 7 2022, 00:55
Reception123 changed the status of subtask T8897: Remove MagicNumberedHeadings from Open to Stalled.Mar 17 2022, 06:02
Reception123 changed the status of subtask T8798: Replace wgUseCategoryBrowser with Ext:CategoryExplorer from Open to Stalled.
Reception123 changed the status of subtask T8899: Remove Tabber from Open to Stalled.
CrystalClear added a subscriber: CrystalClear.Mar 20 2022, 22:37
Agent_Isai changed the status of subtask T8979: Remove GettingStarted from Open to Stalled.Mar 23 2022, 01:33
Universal_Omega added a parent task: T8982: Migrate revision_actor_temp usage back to the revision table.Mar 23 2022, 19:54
Universal_Omega added a subscriber: Universal_Omega.Mar 26 2022, 21:23
Universal_Omega added a subtask: T9000: Verify all Miraheze-developed extensions are compatible with MediaWiki 1.38.0.Mar 27 2022, 15:56
Universal_Omega added a comment.Mar 29 2022, 19:51

Schema changes from extensions (may have missed some though)

Agent_Isai changed the status of subtask T8899: Remove Tabber from Stalled to Open.Apr 1 2022, 19:30
Agent_Isai changed the status of subtask T8899: Remove Tabber from Open to Stalled.
Reception123 added a comment.Apr 18 2022, 16:48

Noting that the current plan is that RhinosF1 will deal with the upgrade on the Beta cluster as soon as RC0 is released.

MacFan4000 added a subscriber: MacFan4000.Apr 20 2022, 19:29
In T8743#184478, @Reception123 wrote:

Noting that the current plan is that RhinosF1 will deal with the upgrade on the Beta cluster as soon as RC0 is released.

RC0 is now released

Universal_Omega added a comment.Apr 29 2022, 06:59

I upgraded the files (not sql yet) on test101:

some errors first:

Deprecated: Template directory should be relative to skin or omitted for skin flatbox [Called from ExtensionProcessor::extractInfo in /srv/mediawiki/w/includes/registration/ExtensionProcessor.php at line 197] in /srv/mediawiki/w/includes/debug/MWDebug.php on line 377


Fatal error: Uncaught UnexpectedValueException: callback 'MapsRegistration::onRegistration' is not callable in /srv/mediawiki/w/includes/registration/ExtensionRegistry.php:572
Stack trace:
#0 /srv/mediawiki/w/includes/registration/ExtensionRegistry.php(258): ExtensionRegistry->exportExtractedData(Array)
#1 /srv/mediawiki/w/includes/Setup.php(252): ExtensionRegistry->loadFromQueue()
#2 /srv/mediawiki/w/maintenance/doMaintenance.php(96): require_once('/srv/mediawiki/...')
#3 /srv/mediawiki/w/maintenance/mergeMessageFileList.php(175): require_once('/srv/mediawiki/...')
#4 {main}
  thrown in /srv/mediawiki/w/includes/registration/ExtensionRegistry.php on line 572

Deprecated: Use of wfWikiID was deprecated in MediaWiki 1.35. [Called from MediaWiki\Extensions\OAuth\Backend\Utils::isCentralWiki in /srv/mediawiki/w/extensions/OAuth/src/Backend/Utils.php at line 25] in /srv/mediawiki/w/includes/debug/MWDebug.php on line 377


MWException from line 596 of /srv/mediawiki/w/includes/cache/localisation/LocalisationCache.php: LocalisationCache::readJSONFile: Invalid JSON file: /srv/mediawiki/w/includes/api/i18n/zh-hant.json
#0 /srv/mediawiki/w/includes/cache/localisation/LocalisationCache.php(929): LocalisationCache->readJSONFile('/srv/mediawiki/...')
#1 /srv/mediawiki/w/includes/cache/localisation/LocalisationCacheBulkLoad.php(100): LocalisationCache->recache('ami')
#2 /srv/mediawiki/w/maintenance/rebuildLocalisationCache.php(253): LocalisationCacheBulkLoad->recache('ami')
#3 /srv/mediawiki/w/maintenance/rebuildLocalisationCache.php(164): RebuildLocalisationCache->doRebuild(Array, Object(LocalisationCacheBulkLoad), false)
#4 /srv/mediawiki/w/maintenance/doMaintenance.php(114): RebuildLocalisationCache->execute()
#5 /srv/mediawiki/w/maintenance/rebuildLocalisationCache.php(281): require_once('/srv/mediawiki/...')
#6 {main}
Universal_Omega added a comment.Apr 29 2022, 19:30
Call to undefined method User::getEffectiveGroups()
from /srv/mediawiki/w/extensions/GroupsSidebar/GroupsSidebar.php(12)
#0 /srv/mediawiki/w/includes/HookContainer/HookContainer.php(338): GroupsSidebar::efHideSidebar(MediaWiki\Skin\Cosmos\SkinCosmos, array)
#1 /srv/mediawiki/w/includes/HookContainer/HookContainer.php(137): MediaWiki\HookContainer\HookContainer->callLegacyHook(string, array, array, array)
#2 /srv/mediawiki/w/includes/HookContainer/HookRunner.php(3431): MediaWiki\HookContainer\HookContainer->run(string, array)
#3 /srv/mediawiki/w/includes/skins/Skin.php(1543): MediaWiki\HookContainer\HookRunner->onSkinBuildSidebar(MediaWiki\Skin\Cosmos\SkinCosmos, array)
#4 /srv/mediawiki/w/includes/skins/Skin.php(1572): Skin->{closure}()
#5 /srv/mediawiki/w/includes/skins/SkinTemplate.php(784): Skin->buildSidebar()
#6 /srv/mediawiki/w/includes/skins/SkinTemplate.php(754): SkinTemplate->getPortletsTemplateData()
#7 /srv/mediawiki/w/includes/skins/Skin.php(657): SkinTemplate->getCategoryLinks()
#8 /srv/mediawiki/w/includes/skins/SkinTemplate.php(232): Skin->getCategories()
#9 /srv/mediawiki/w/includes/skins/SkinTemplate.php(133): SkinTemplate->prepareQuickTemplate()
#10 /srv/mediawiki/w/includes/skins/SkinTemplate.php(150): SkinTemplate->generateHTML()
#11 /srv/mediawiki/w/includes/OutputPage.php(2807): SkinTemplate->outputPage()
#12 /srv/mediawiki/w/includes/MediaWiki.php(924): OutputPage->output(boolean)
#13 /srv/mediawiki/w/includes/MediaWiki.php(937): MediaWiki::{closure}()
#14 /srv/mediawiki/w/includes/MediaWiki.php(564): MediaWiki->main()
#15 /srv/mediawiki/w/index.php(53): MediaWiki->run()
#16 /srv/mediawiki/w/index.php(46): wfIndexMain()
#17 {main}
Universal_Omega updated the task description. (Show Details)Apr 29 2022, 21:16
Universal_Omega closed subtask T8798: Replace wgUseCategoryBrowser with Ext:CategoryExplorer as Resolved.Apr 29 2022, 22:15
Universal_Omega updated the task description. (Show Details)Apr 29 2022, 22:37
Universal_Omega updated the task description. (Show Details)
Universal_Omega closed subtask T8786: Make sure npm works or create deploy repo for femiwiki as Resolved.Apr 30 2022, 06:20
Universal_Omega updated the task description. (Show Details)Apr 30 2022, 17:06
Universal_Omega moved this task from Backlog to Features on the MediaWiki board.May 9 2022, 19:16
Universal_Omega moved this task from Backlog to Short Term on the MediaWiki (SRE) board.
Ajhalili2006 added a subscriber: Ajhalili2006.May 11 2022, 09:43
LisafBia added a subscriber: LisafBia.May 24 2022, 09:31
Universal_Omega added a comment.Jun 2 2022, 23:04

Stable 1.38.0 is now released.

MacFan4000 raised the priority of this task from Normal to High.Jun 2 2022, 23:08

Now that it’s out this is high priority since we advertise that we run the latest version.

Universal_Omega changed the status of subtask T8899: Remove Tabber from Stalled to Open.Jun 5 2022, 20:13
Universal_Omega changed the status of subtask T8897: Remove MagicNumberedHeadings from Stalled to Open.Jun 5 2022, 20:15
Universal_Omega changed the status of subtask T8979: Remove GettingStarted from Stalled to Open.
Universal_Omega closed subtask T8899: Remove Tabber as Resolved.Jun 5 2022, 21:49
Universal_Omega added a comment.Jun 6 2022, 02:05
This comment was removed by Universal_Omega.
Reception123 added a comment.EditedJun 6 2022, 12:08

Once all extensions have been tested, we should decide when the upgrade should take place. The best time for most people seems to be on a weekend (or Friday) after 21:00 UTC. I propose that the earliest target period could be 17-19 June and the latest could be 24-26 June depending on how testing goes and if there's issues with extensions to be resolved

Universal_Omega renamed this task from Upgrade to MediaWiki 1.38.0 to Upgrade to MediaWiki 1.38.1.Jun 6 2022, 15:31
Universal_Omega updated the task description. (Show Details)
Universal_Omega closed subtask T9000: Verify all Miraheze-developed extensions are compatible with MediaWiki 1.38.0 as Resolved.Jun 7 2022, 20:29
Universal_Omega added a subtask: T9351: Remove GroupsSidebar.Jun 7 2022, 20:32
Universal_Omega closed subtask T9351: Remove GroupsSidebar as Declined.
Universal_Omega added a subtask: T9357: Remove HeaderFooter.Jun 8 2022, 07:48
Universal_Omega updated the task description. (Show Details)Jun 8 2022, 08:00
Universal_Omega closed subtask T9163: Test all extensions for 1.38 as Resolved.Jun 8 2022, 16:18
Reception123 added a comment.EditedJun 8 2022, 19:25

With all extensions having been tested, the upgrade is now proposed for June 15 between 20:00-22:00 UTC.

Reception123 updated the task description. (Show Details)Jun 8 2022, 19:26
Reception123 updated the task description. (Show Details)
Reception123 added a subscriber: John.
Universal_Omega added a subtask: T9168: Remove Skin:Foreground.Jun 12 2022, 22:28
Universal_Omega added a subtask: T7876: Remove AddThis and replace with Agent Isai's extension.Jun 12 2022, 22:32
Universal_Omega closed subtask T7876: Remove AddThis and replace with Agent Isai's extension as Resolved.Jun 12 2022, 22:35
Universal_Omega closed subtask T9357: Remove HeaderFooter as Resolved.Jun 12 2022, 22:37
Universal_Omega closed subtask T8897: Remove MagicNumberedHeadings as Resolved.
Universal_Omega closed subtask T8979: Remove GettingStarted as Resolved.
Universal_Omega closed subtask T9340: Remove Skin:Pivot as Resolved.
Universal_Omega closed subtask T9168: Remove Skin:Foreground as Resolved.
Universal_Omega closed subtask T9343: Remove FancyBoxThumbs as Resolved.
MacFan4000 updated the task description. (Show Details)Jun 14 2022, 15:22
Agent_Isai updated the task description. (Show Details)Jun 14 2022, 15:36
RhinosF1 updated the task description. (Show Details)Jun 15 2022, 16:49
Agent_Isai updated the task description. (Show Details)Jun 15 2022, 17:30
Universal_Omega closed this task as Resolved.Jun 16 2022, 00:25
Universal_Omega claimed this task.

Upgrade completed.