Page MenuHomeMiraheze

Make sure npm works or create deploy repo for femiwiki
Closed, ResolvedPublic

Event Timeline

RhinosF1 created this task.

@Universal_Omega: Can you create the repo? I can get it actually deployed.

@Universal_Omega: Can you create the repo? I can get it actually deployed.

I don't like the idea of a deploy repo for npm modules to use with a submodule. But if we really want to go here then sure, I can probably do that a bit later on.

It shouldn't cause an issue. I can't really think of a better way.

RhinosF1 raised the priority of this task from Low to High.EditedMar 2 2022, 20:19

Test deployment can be from 17th March

@Universal_Omega: status?

I'll try and get this done within the next few days (this week).

Reception123 lowered the priority of this task from High to Normal.Mar 3 2022, 07:10

Doing something for a 'test deployment' is by definition not high priority for me. Unless something absolutely needs to be done in the next few days because it is harming production I don't really see why it should be high priority.

What's the next steps here? And status?

I am curious why only femiwiki requires special additional steps. Is it because it is a skin? I guess some other extensions also require npm dependencies. Is there a thing to do for me, as a maintainer of the skin?

I am curious why only femiwiki requires special additional steps. Is it because it is a skin? I guess some other extensions also require npm dependencies. Is there a thing to do for me, as a maintainer of the skin?

It's because NPM doesn't work due to us being IPV6, and GitHub being IPV4, so getting NPM dependencies from GitHub didn't work, it seems, from my understanding at least.

You could vendor the dependencies by default.

You could vendor the dependencies by default.

The tarball releases of the skin already vendor the dependencies. [1] In my opinion, downloading skin/extension by cloning as a submodule is not a usual case so I hope to try the solution only as of the last.

It's because NPM doesn't work due to us being IPV6, and GitHub being IPV4, so getting NPM dependencies from GitHub didn't work, it seems, from my understanding at least.

Is it means the below clause in package.json?

"dependencies": {
  "@femiwiki/ooui-femiwiki-theme": "https://github.com/femiwiki/OOUIFemiwikiTheme.git#main",
  "xeicon": "https://github.com/xpressengine/XEIcon.git#2.3.3"
}

If in that case, I could publish the repository on NPM.

1: https://github.com/femiwiki/FemiwikiSkin/releases/latest