Page MenuHomeMiraheze
Create Task
Maniphest T8904

Missing icons in page actions for the Citizen skin
Closed, InvalidPublic
Actions

Description

Wiki URL: https://projectsekai.miraheze.org/wiki/Main_Page

A couple days ago, the icons for each page action have disappeared on the Citizen Skin. This is particularly an issue on thinner viewports since there's no text showing where each button is and describing what it does.

VieportCurrentExpected
Wide
wide_current.png (55×329 px, 1 KB)
wide_expected.png (56×282 px, 1 KB)
Thin
thin_current.png (56×196 px, 486 B)
thin_expected.png (51×133 px, 1 KB)

Expected screenshots taken from the Star Citizen Wiki.

Event Timeline

ChaoticShadow created this task.Mar 7 2022, 22:21
Herald added subscribers: Agent_Isai, RhinosF1. · View Herald TranscriptMar 7 2022, 22:21
Agent_Isai triaged this task as Normal priority.Mar 8 2022, 01:15
Agent_Isai added projects: MediaWiki, MediaWiki (SRE).
Herald added a subscriber: Reception123. · View Herald TranscriptMar 8 2022, 01:15
ChaoticShadow added a comment.Mar 11 2022, 01:06

I did some digging and found that there are no ids assigned to any of the action links (like #ca-history is missing from the link for history). Looking at the Star Citizen Wiki, it appears that these selectors style the buttons.

We also noticed that Visual Editor is broken in the Citizen skin too, and based on the requirements it's probably because #ca-edit is missing.

Agent_Isai closed this task as Invalid.Mar 11 2022, 05:43
Agent_Isai moved this task from Backlog to Short Term on the MediaWiki (SRE) board.

It seems that this is an upstream issue which is beyond our scope and is being already tracked on GitHub. Closing as invalid per the aforementioned.

Agent_Isai moved this task from Backlog to Upstream on the MediaWiki board.Mar 11 2022, 05:43
Lens0021 added a subscriber: Lens0021.Mar 22 2022, 08:49
Lens0021 added a comment.Mar 22 2022, 08:52
In T8904#180333, @Agent_Isai wrote:

It seems that this is an upstream issue which is beyond our scope and is being already tracked on GitHub. Closing as invalid per the aforementioned.

https://github.com/StarCitizenTools/mediawiki-skins-Citizen/issues/435 (Visual Editor incompatability, missing icons for page actions) seems to be more suitable.

Alistair3149 added a subscriber: Alistair3149.Apr 15 2022, 15:39

It should be fixed by the PR from @Lens0021 now.
https://github.com/StarCitizenTools/mediawiki-skins-Citizen/pull/440

Herald added a subscriber: Universal_Omega. · View Herald TranscriptApr 15 2022, 15:39