Page MenuHomeMiraheze
Create Task
Maniphest T9056

DPL3 Fatal exception of type "TypeError" (stack trace please)
Closed, ResolvedPublic
Actions

Description

Wiki: dpl3.miraheze.org

Full exception (with ID):
[663fa646696a13538245efcd] 2022-04-09 23:36:24: Fatal exception of type "TypeError"

Can the stack trace for this please be posted? Thanks! :)

To reproduce (if needed):

  1. Copy/paste the following DPL3 query to any page (on the dpl3 wiki):
{{#dpl:
|imagecontainer = Orange
|count=2
|openreferences=yes
|ordermethod=none
|noresultsheader=\n''Doesn't work''
}}
  1. Preview or attempt to save the result, to see the fatal exception; OR, you can view/edit this page to trigger the exception (if needed): https://dpl3.miraheze.org/wiki/User:FrozenPlum/Sandbox/Issues2

Thanks!

Related Objects

Event Timeline

FrozenPlum created this task.Apr 9 2022, 23:48
Herald added subscribers: Agent_Isai, RhinosF1, Reception123. · View Herald TranscriptApr 9 2022, 23:48
Universal_Omega triaged this task as Normal priority.Apr 10 2022, 15:54
Universal_Omega added projects: MediaWiki (SRE), Extensions.

Just to note I requested that this task be created since I wasn't around to get the stack trace, and they opened an issue on Github, which I need the full error be given in order to debug it. So this task is simply asking for the log, nothing more. Once given it can be closed as resolved.

Universal_Omega moved this task from Backlog to Deployed Extension Bugs on the Extensions board.Apr 10 2022, 15:54
Universal_Omega moved this task from Backlog to Short Term on the MediaWiki (SRE) board.
Universal_Omega closed this task as Resolved.Apr 12 2022, 18:40
Universal_Omega claimed this task.
Argument 5 passed to MediaWiki\Extension\DynamicPageList3\Article::newFromRow() must be of the type string, null given, called in /srv/mediawiki/w/extensions/DynamicPageList3/includes/Parse.php on line 409
from /srv/mediawiki/w/extensions/DynamicPageList3/includes/Article.php(198)
#0 /srv/mediawiki/w/extensions/DynamicPageList3/includes/Parse.php(409): MediaWiki\Extension\DynamicPageList3\Article::newFromRow(stdClass, MediaWiki\Extension\DynamicPageList3\Parameters, Title, integer, NULL)
#1 /srv/mediawiki/w/extensions/DynamicPageList3/includes/Parse.php(221): MediaWiki\Extension\DynamicPageList3\Parse->processQueryResults(array, Parser)
#2 /srv/mediawiki/w/extensions/DynamicPageList3/includes/Hooks.php(274): MediaWiki\Extension\DynamicPageList3\Parse->parse(string, Parser, NULL, NULL, boolean)
#3 /srv/mediawiki/w/includes/parser/Parser.php(3407): MediaWiki\Extension\DynamicPageList3\Hooks::dplParserFunction(Parser, string, string, string, string, string, string)
#4 /srv/mediawiki/w/includes/parser/Parser.php(3092): Parser->callParserFunction(PPFrame_Hash, string, array)
#5 /srv/mediawiki/w/includes/parser/PPFrame_Hash.php(273): Parser->braceSubstitution(array, PPFrame_Hash)
#6 /srv/mediawiki/w/includes/parser/Parser.php(2930): PPFrame_Hash->expand(PPNode_Hash_Tree, integer)
#7 /srv/mediawiki/w/includes/parser/Parser.php(1598): Parser->replaceVariables(string)
#8 /srv/mediawiki/w/includes/parser/Parser.php(656): Parser->internalParse(string)
#9 /srv/mediawiki/w/includes/content/WikitextContent.php(327): Parser->parse(string, Title, ParserOptions, boolean, boolean, NULL)
#10 /srv/mediawiki/w/includes/content/AbstractContent.php(548): WikitextContent->fillParserOutput(Title, NULL, ParserOptions, boolean, ParserOutput)
#11 /srv/mediawiki/w/includes/EditPage.php(4214): AbstractContent->getParserOutput(Title, NULL, ParserOptions)
#12 /srv/mediawiki/w/includes/EditPage.php(4117): EditPage->doPreviewParse(WikitextContent)
#13 /srv/mediawiki/w/includes/EditPage.php(2895): EditPage->getPreviewText()
#14 /srv/mediawiki/w/includes/EditPage.php(722): EditPage->showEditForm()
#15 /srv/mediawiki/w/includes/actions/EditAction.php(71): EditPage->edit()
#16 /srv/mediawiki/w/includes/actions/SubmitAction.php(38): EditAction->show()
#17 /srv/mediawiki/w/includes/MediaWiki.php(543): SubmitAction->show()
#18 /srv/mediawiki/w/includes/MediaWiki.php(320): MediaWiki->performAction(Article, Title)
#19 /srv/mediawiki/w/includes/MediaWiki.php(930): MediaWiki->performRequest()
#20 /srv/mediawiki/w/includes/MediaWiki.php(564): MediaWiki->main()
#21 /srv/mediawiki/w/index.php(53): MediaWiki->run()
#22 /srv/mediawiki/w/index.php(46): wfIndexMain()
#23 {main}
Routhwick added a subscriber: Routhwick.Aug 8 2022, 01:39

Practically ran into the same "openreferences" error while setting up the home page for my "FTA" (From the Author) feature earlier this overnight. (Even the example at Follow the Score's manual [source code provided here] throws up an error.) To UO: Once/if looked into, can you provide an ETA for an upstream fix?

Already a boon for link lists, "openreferences" would really benefit pages with Commons-sourced images once repaired, because the setup in its current state can only detect local uploads (much to this contributor's own chagrin).

Routhwick reopened this task as Open.Aug 8 2022, 01:42
Universal_Omega added a comment.Aug 8 2022, 02:34

This is not the same issue it seems. Can you please copy the new exception that you get?

Routhwick added a comment.Aug 8 2022, 02:49

When sandboxed at ExpandTemplates with {{#dpl:imagecontainer=From the Author:2022/Anniversary ashcan|openreferences=true}} (itself containing several CC0 images from the Commons):

Internal error

[c5fad8305601b90eb109d8dc] 2022-08-08 02:41:26: Fatal exception of type "TypeError"

And besides, shouldn't "openreferences=true" be "openreferences=yes" in line with the text-focused version?

Routhwick mentioned this in T9643: DPL3 parsing bug: Triple left brackets block rest of access to parameters.Aug 8 2022, 19:46
Universal_Omega added a comment.Aug 11 2022, 19:52
Argument 5 passed to MediaWiki\Extension\DynamicPageList3\Article::newFromRow() must be of the type string, null given, called in /srv/mediawiki/w/extensions/DynamicPageList3/includes/Parse.php on line 415
from /srv/mediawiki/w/extensions/DynamicPageList3/includes/Article.php(198)
#0 /srv/mediawiki/w/extensions/DynamicPageList3/includes/Parse.php(415): MediaWiki\Extension\DynamicPageList3\Article::newFromRow(stdClass, MediaWiki\Extension\DynamicPageList3\Parameters, Title, integer, NULL)
#1 /srv/mediawiki/w/extensions/DynamicPageList3/includes/Parse.php(227): MediaWiki\Extension\DynamicPageList3\Parse->processQueryResults(array, Parser)
#2 /srv/mediawiki/w/extensions/DynamicPageList3/includes/Hooks.php(275): MediaWiki\Extension\DynamicPageList3\Parse->parse(string, Parser, NULL, NULL, boolean)
#3 /srv/mediawiki/w/includes/parser/Parser.php(3413): MediaWiki\Extension\DynamicPageList3\Hooks::dplParserFunction(Parser, string, string)
#4 /srv/mediawiki/w/includes/parser/Parser.php(3096): Parser->callParserFunction(PPFrame_Hash, string, array)
#5 /srv/mediawiki/w/includes/parser/PPFrame_Hash.php(276): Parser->braceSubstitution(array, PPFrame_Hash)
#6 /srv/mediawiki/w/includes/parser/Parser.php(2932): PPFrame_Hash->expand(PPNode_Hash_Tree, integer)
#7 /srv/mediawiki/w/includes/parser/Parser.php(931): Parser->replaceVariables(string, PPFrame_Hash)
#8 /srv/mediawiki/w/includes/specials/SpecialExpandTemplates.php(114): Parser->preprocess(string, Title, ParserOptions)
#9 /srv/mediawiki/w/includes/specialpage/SpecialPage.php(671): SpecialExpandTemplates->execute(NULL)
#10 /srv/mediawiki/w/includes/specialpage/SpecialPageFactory.php(1378): SpecialPage->run(NULL)
#11 /srv/mediawiki/w/includes/MediaWiki.php(315): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#12 /srv/mediawiki/w/includes/MediaWiki.php(912): MediaWiki->performRequest()
#13 /srv/mediawiki/w/includes/MediaWiki.php(563): MediaWiki->main()
#14 /srv/mediawiki/w/index.php(53): MediaWiki->run()
#15 /srv/mediawiki/w/index.php(46): wfIndexMain()
#16 {main}

so it does appear to be the same issue, but I thought that I fixed that, so this is a bit weird. Guess it was not fully fixed.

Herald removed a subscriber: RhinosF1. · View Herald TranscriptAug 11 2022, 19:52
Universal_Omega added a comment.Aug 11 2022, 20:52

https://github.com/Universal-Omega/DynamicPageList3/commit/6ca7c458be822f32905b814f1b9e9ff2dd70e035 should fix it now.

Universal_Omega closed this task as Resolved.Aug 11 2022, 21:15
Universal_Omega added a project: Upstream.

DPL3 updated. Please let me know if it worked. Thanks!

Routhwick added a comment.Aug 11 2022, 23:55

A-OK!