Page MenuHomeMiraheze
Create Task
Maniphest T9161

HTTP 500 error on saving edits on talk pages of property namespace
Closed, ResolvedPublic
Actions

Description

This has been happening from inception though, I've just been lazy in reporting it. When I try to save edits with the Property documentation template in the talk pages on Properties (let's say forexample; Property_talk:613) it throws HTTP 500 error.

to test it out, you can go to the above property talk, then just insert {{Property documentation}} and try to save.

How can we resolve this?

Revisions and Commits

rPUPC Puppet Configuration
rPUPCcf2f78a76e87 Raise base PHP memory limit to 256MB (#2525)

Related Objects

Event Timeline

Excelsis triaged this task as Normal priority.Apr 29 2022, 15:26
Excelsis created this task.
Herald added subscribers: Agent_Isai, Unknown Object (User), RhinosF1, Reception123. · View Herald TranscriptApr 29 2022, 15:26
Reception123 added a comment.Apr 29 2022, 16:36
PHP Fatal Error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 20480 bytes)
from /srv/mediawiki/w/includes/libs/objectcache/MemcachedPeclBagOStuff.php(341)
#0 [internal function]: MWExceptionHandler::handleFatalError()
#1 {main}
Reception123 added a comment.Apr 29 2022, 16:38

Noting that similar error existed in T8866, ultimately resolved by @Universal_Omega

Unknown Object (User) added a comment.May 1 2022, 17:18

I will try and investigate this further, this week.

Unknown Object (User) added a comment.May 2 2022, 23:21
In T9161#185641, @Reception123 wrote:
PHP Fatal Error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 20480 bytes)
from /srv/mediawiki/w/includes/libs/objectcache/MemcachedPeclBagOStuff.php(341)
#0 [internal function]: MWExceptionHandler::handleFatalError()
#1 {main}

I just realised this, where does that limit (134217728 bytes/128MB) even come from? Even for us, I think that is a little bit low, though I can't remember our max limit right now. The only thing limited at that, which I could find is ImageMagick being limited at that, but I'm not sure how that'd cause issues in this circumstance.

Unknown Object (User) added a comment.May 2 2022, 23:56

Oh. https://github.com/miraheze/puppet/blob/15dee3da9258f608fab6d7534ead9cfd158d7873/modules/php/manifests/init.pp#L38 — but that should have been override to 256MB by mediawiki config. It may not have been the case. I'm not sure, but something seems wrong here. https://github.com/miraheze/puppet/blob/fe1e35a4010e445892e1fe45550be38c13989be4/modules/mediawiki/manifests/php.pp#L10 must be defined from the base php class, so I guess https://github.com/miraheze/puppet/blob/fe1e35a4010e445892e1fe45550be38c13989be4/modules/mediawiki/manifests/php.pp#L20 never receives the override to take an effect, I assume?

Unknown Object (User) added a comment.EditedMay 3 2022, 00:08

https://github.com/miraheze/puppet/pull/2525 raised the base limit to match the defaults.

Unknown Object (User) added a commit: rPUPCcf2f78a76e87: Raise base PHP memory limit to 256MB (#2525).May 3 2022, 00:10
Unknown Object (User) added a comment.May 3 2022, 00:25

Can you please confirm if it works for you now?

Excelsis added a comment.May 3 2022, 05:53

It doesn't, it still returns Http 500

Unknown Object (User) added a comment.May 3 2022, 15:55
In T9161#185896, @Ugochimobi wrote:

It doesn't, it still returns Http 500

I noticed. Still investigating.

Excelsis added a comment.May 3 2022, 16:41

Yeah. I don't know if this is related but on Gratispaideia, there's a Lua error that appears when you visit https://gratispaideia.miraheze.org/wiki/Template:Infobox_building

It is partially persistent.

Unknown Object (User) closed this task as Resolved.May 5 2022, 00:08
Unknown Object (User) claimed this task.

I can now confirm I was able to save Property talk:P613. It seems the changes I made with the mentioned PR was not applied, once I restarted PHP-FPM on mw* it now appears to work.