Page MenuHomeMiraheze
Create Task
Maniphest T9712

mw-config master is broken
Closed, ResolvedPublic
Actions

Description

Has a syntax error. Luckily canary has blocked rollout to prod. Beta is down.

Was force pushed without waiting for CI by John @ 19:56

Event Timeline

RhinosF1 triaged this task as Unbreak Now! priority.Aug 29 2022, 19:11
RhinosF1 created this task.
Herald added subscribers: Agent_Isai, Unknown Object (User), Reception123. · View Herald TranscriptAug 29 2022, 19:11
John closed this task as Resolved.Aug 29 2022, 19:19
John claimed this task.
John subscribed.

"Was force pushed without waiting for CI by John @ 19:56"

It wasn't forced pushed - it was committed?

John added a comment.Aug 29 2022, 19:21

https://github.com/miraheze/mw-config/commit/212136fee36e73f4c6d8fe1dd022a8af211dedab is where behaviour changes and likely the source of the breaking change

RhinosF1 added a comment.Aug 29 2022, 19:52
In T9712#196193, @John wrote:

"Was force pushed without waiting for CI by John @ 19:56"

It wasn't forced pushed - it was committed?

Clarification: CI there to point out exactly this was bypassed by merging without a PR and then when post merged failed completely ignored for about 10 minutes

John added a comment.Aug 29 2022, 21:39
In T9712#196202, @RhinosF1 wrote:
In T9712#196193, @John wrote:

"Was force pushed without waiting for CI by John @ 19:56"

It wasn't forced pushed - it was committed?

Clarification: CI there to point out exactly this was bypassed by merging without a PR and then when post merged failed completely ignored for about 10 minutes

It wasn't ignored, I was looking at it, I then made a request that I couldn't see the problem and you filed this task and provided unhelpful responses to assist in debugging what came across like a problem you knew how to fix.