Page MenuHomeMiraheze

Samwilson (Sam Wilson)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 20 2017, 01:57 (283 w, 3 d)
Availability
Available
IRC Nickname
samwilson
GitHub User
samwilson
Miraheze User
Samwilson [ Global Accounts ]

For more information about me, see https://samwilson.id.au/

Recent Activity

Apr 14 2022

Samwilson added a comment to T9061: CreateRedirect has weak (no?) permissions checks.

I mentioned the CreateRedirect error on its talk page (sorry, I didn't realise this was a hidden security task! I shouldn't've advertised it publicly), and it looks like the issue has been fixed: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CreateRedirect/+/780567

Apr 14 2022, 10:57 · Extensions, Trust & Safety, MediaWiki (SRE), Security
Samwilson added a comment to T9061: CreateRedirect has weak (no?) permissions checks.

I'm not a member, just watching that project.

Apr 14 2022, 06:05 · Extensions, Trust & Safety, MediaWiki (SRE), Security

Jan 10 2022

Herald added projects to T3337: Add an osmf-mediawiki skin to my wiki: Universal Omega, MediaWiki (SRE).

It sounds like the logo issue is fixed now.

Jan 10 2022, 00:51 · MediaWiki (SRE), Universal Omega, Extensions, Extension-Review

Oct 26 2021

Samwilson added a comment to T8211: Change skin my wikiworld.

Yes, as documented at https://www.mediawiki.org/wiki/Skin:WMAU

Oct 26 2021, 00:48 · MediaWiki (SRE), Extensions, Universal Omega

Oct 25 2021

Samwilson added a comment to T8211: Change skin my wikiworld.

Oh, and in case it's not obvious from the above link: we're running this skin in production on https://wikimedia.org.au

Oct 25 2021, 22:48 · MediaWiki (SRE), Extensions, Universal Omega
Samwilson added a comment to T8211: Change skin my wikiworld.

This is one of yours. Any issues/comments/things we should know?

Oct 25 2021, 22:47 · MediaWiki (SRE), Extensions, Universal Omega

Jan 7 2021

Samwilson added a comment to T6607: Request Commentbox extension.

I'll have a look at improving it.

Jan 7 2021, 23:58 · Extensions, Universal Omega

Oct 14 2020

Samwilson added a comment to T6311: Extension:Mermaid fatal error.

@RhinosF1 nope, I've used it a bit, but am not the maintainer. I'm not sure who to ping, but it looks like they manage issues on Github: https://github.com/SemanticMediaWiki/Mermaid/issues

Oct 14 2020, 07:31 · Upstream, Production Error, Universal Omega, Extensions

Aug 1 2020

Samwilson added a comment to T5975: Extension:MediaWiki-CalendarConverter.

The code here looks sort of old-ish, but fine from what I can see. However, an error is being thrown about the registration of the parser functions:

Aug 1 2020, 11:46 · MediaWiki (SRE), Universal Omega, Extensions
Samwilson added a comment to T5999: Extension:Tabs - MobileTabsPlugin.

This looks fine to install, I think.

Aug 1 2020, 11:30 · Extensions

Jul 28 2020

Samwilson added a comment to T5815: Extension:JsCalendar.

I haven't delved completely into the code here, but it looks pretty good from what I can see. I think this is good to install.

Jul 28 2020, 01:25 · Universal Omega, Configuration, Extensions

Jul 27 2020

Samwilson added a comment to T5936: Extension:Expiry.

It requires the BlueSpiceFoundation extension, so it sounds like this is not possible.

Jul 27 2020, 22:16 · Extensions

May 20 2020

Samwilson added a comment to T5204: Extension:Mermaid and Diagrams dependencies.

I'm glad you like the Genealogy extension!

May 20 2020, 22:35 · Upstream, Extensions, Configuration
Samwilson added a comment to T5512: Extension:DeletePagesForGood.

the pages still show up on Special:Nuke for some reason, even though they're """deleted"""

May 20 2020, 04:20 · Extensions

May 19 2020

Samwilson added a comment to T5512: Extension:DeletePagesForGood.

I shifted totally the focus of my wiki and over 500 templates that I imported originally doesn't have any use now

May 19 2020, 23:03 · Extensions
Samwilson added a comment to T5512: Extension:DeletePagesForGood.

even if I delete the articles, they aren't really deleted

May 19 2020, 08:01 · Extensions

May 6 2020

Samwilson added a comment to T5544: Extension review: TitleKey on ccwikiwiki.

Wikipedia doesn't seem to be using SaneCase, so I'm wondering if it uses a better alternative? I'm trying to achieve the same thing where links aren't case-sensitive.

May 6 2020, 21:31 · Configuration, Extensions
Samwilson added a comment to T5544: Extension review: TitleKey on ccwikiwiki.

A few things:

May 6 2020, 11:51 · Configuration, Extensions
Samwilson added a comment to T4788: Extension review: Avatar.

It creates its own web entry point, extensions/Avatar/avatar.php, as well as a custom file-upload process. Both of these things are a security risk. I'm not saying that there's any particular vulnerability with either of them (I haven't looked). There are other, more secure and well-known, ways of doing what it's trying to do.

May 6 2020, 04:56 · Configuration, Extensions
Samwilson added a comment to T5450: Request Markdown extension and some skins.

Sorry I've not been reviewing much lately. There are too many fun projects in life!

May 6 2020, 04:38 · Extensions, Amanda Catherine, Configuration

Apr 13 2020

Samwilson added a comment to T5204: Extension:Mermaid and Diagrams dependencies.

I don't think Diagrams is suitable for the Miraheze environment, as it requires the installation of a separate web service.

Apr 13 2020, 02:24 · Upstream, Extensions, Configuration

Mar 3 2020

Samwilson added a comment to T5005: Update version of Extension Genealogy.

PR: https://github.com/miraheze/mediawiki/pull/133

Mar 3 2020, 06:39 · Extensions, Configuration

Feb 25 2020

Samwilson added a comment to T5204: Extension:Mermaid and Diagrams dependencies.

You are marked a maintainer for it so do you want to have a look?

Feb 25 2020, 05:04 · Upstream, Extensions, Configuration

Feb 1 2020

Samwilson added a comment to T5180: Extension:GraphViz.

GraphViz is not compatible with 1.33 (see https://phabricator.wikimedia.org/T226616 ), but if you want to get started with Genealogy now you can enable the Mermaid extension and use |format=mermaid in the tree parser function. It's a slightly clunky layout sometimes though, and slows down page load times.

Feb 1 2020, 18:38 · Configuration

Dec 23 2019

RhinosF1 awarded T5005: Update version of Extension Genealogy a Like token.
Dec 23 2019, 15:11 · Extensions, Configuration
Samwilson added a comment to T5005: Update version of Extension Genealogy.

That was quick!! :) Thanks.

Dec 23 2019, 10:26 · Extensions, Configuration
Samwilson added a comment to T5005: Update version of Extension Genealogy.

It looks like Miraheze is at 1.34 now, is that right?

Dec 23 2019, 10:26 · Extensions, Configuration
Samwilson added a comment to T5005: Update version of Extension Genealogy.

There's a couple of tweaks required it sounds like; I'm going to look into them first and release a new version of this — and then will update the version here. (Doing that is just a matter of updating the Git submodule in https://github.com/miraheze/mediawiki isn't it?)

Dec 23 2019, 00:45 · Extensions, Configuration

Aug 1 2019

Samwilson added a comment to T4588: TemplateWizard not working.

It doesn't seem to be installed on publictestwiki.com

Aug 1 2019, 07:22 · Extensions
Samwilson added a comment to T4588: TemplateWizard not working.

Sorry to hear it's not working. What's the error? Anything in the browser console? Does the toolbar button get added correctly?

Aug 1 2019, 07:11 · Extensions

Jul 23 2019

Samwilson added a comment to T4555: Enable Special404 and ConfirmEdit on communitycentralbympteam.miraheze.org.

You can find the name of the message to modify on any page with the ?uselang=qqx special language code. For example, if you want to change the message shown for invalid special page names, go to e.g. https://en.wikipedia.org/wiki/Special:BadPageName?uselang=qqx and see that the message is nospecialpagetext (the BadPageName is just a random string that is not a valid special page name; it could be anything).

Jul 23 2019, 04:39 · Extension-Review, Extensions, Configuration

Jul 22 2019

Samwilson added a comment to T4555: Enable Special404 and ConfirmEdit on communitycentralbympteam.miraheze.org.

@DekuPH2006AJHalili I read that, but it doesn't explain why this is better than just modifying the mediawiki:noarticletext message, which is displayed when a page is not found. It seems that the extension requires setting up a separate 404 handler for the webserver, pointing to the extension's special page. But MediaWiki already has a built-in page that it displays in those situations.

Jul 22 2019, 01:40 · Extension-Review, Extensions, Configuration

Jul 19 2019

Samwilson added a comment to T4555: Enable Special404 and ConfirmEdit on communitycentralbympteam.miraheze.org.

I'm probably missing something, but what's the point of Special404? It seems to be about the same as modifying the core noarticletext message. It also requires modifying the web server configuration, so I'm not sure if it's appropriate for the Miraheze environment.

Jul 19 2019, 23:54 · Extension-Review, Extensions, Configuration

Feb 14 2019

Samwilson added a comment to T4105: A word cloud extension request.

(Thanks to Reception123 for relaying my message earlier; I was locked out of Phabricator here.)

Feb 14 2019, 06:47 · Extensions
Samwilson added a comment to T4105: A word cloud extension request.

@Void no you could still do things like this:

Feb 14 2019, 06:46 · Extensions

Oct 7 2018

Samwilson added a comment to T3576: Migrate Wikimedia Australia wikis to Miraheze.

Thanks for that. WMAU is sending a donation to Miraheze in appreciation.

Oct 7 2018, 00:14 · MediaWiki, Import

Oct 1 2018

Samwilson added a comment to T3576: Migrate Wikimedia Australia wikis to Miraheze.

So the Committee has decided not to proceed with the migration.

Oct 1 2018, 02:36 · MediaWiki, Import

Sep 21 2018

Samwilson added a comment to T3619: Extension:Multi-Category Search.

I haven't had a chance to look at https://www.mediawiki.org/wiki/Extension:Multi-Category_Search yet, but in the meantime would the existing DPL extension be of any help? e.g.

Sep 21 2018, 05:16 · MacFan4000, Extensions, Extension-Review
Samwilson added a comment to T3487: Enable Regex Fun on rageofbahamut.miraheze.org.

Does this extension provide any functionality that's not already available in Lua modules?

Sep 21 2018, 04:54 · Amanda Catherine

Sep 16 2018

Samwilson added a comment to T3576: Migrate Wikimedia Australia wikis to Miraheze.

The WMAU committee has a meeting tomorrow, where the next stage will be decided. Gotta get people to approve where we're up to so far. :-)

Sep 16 2018, 01:37 · MediaWiki, Import
Samwilson closed T3601: Setting permission recreatecargodata doesn't work as Resolved.

Thank you!!

Sep 16 2018, 01:32 · Amanda Catherine, ManageWiki

Sep 15 2018

Samwilson created T3601: Setting permission recreatecargodata doesn't work.
Sep 15 2018, 07:49 · Amanda Catherine, ManageWiki

Sep 13 2018

Samwilson added a comment to T3576: Migrate Wikimedia Australia wikis to Miraheze.

Good point; yeah, that should be fine.

Sep 13 2018, 00:43 · MediaWiki, Import

Sep 12 2018

Samwilson added a comment to T3576: Migrate Wikimedia Australia wikis to Miraheze.

Thank you! Looks great. And yep, I'll get on to the main wiki shortly. :) This is exciting!

Sep 12 2018, 22:54 · MediaWiki, Import
Samwilson added a comment to T3576: Migrate Wikimedia Australia wikis to Miraheze.

By the way, is wmaucomm correctly set to private? I seem to be able to browse without being logged in.

Sep 12 2018, 07:31 · MediaWiki, Import
Samwilson added a comment to T3473: Requesting ApprovedRevs extension..

The code looks good here, and the author is trusted. I'd say this could be installed.

Sep 12 2018, 00:45 · Extensions, MacFan4000

Sep 11 2018

Samwilson added a comment to T3576: Migrate Wikimedia Australia wikis to Miraheze.

I don't know what the problem was, but I ran fixDoubleRedirects.php and rebuildall.php and everything now exports correctly. Some wayward link record I guess.

Sep 11 2018, 22:55 · MediaWiki, Import
Samwilson added a comment to T3576: Migrate Wikimedia Australia wikis to Miraheze.

I'm attempting to run dumpBackup.php, and hitting a bug. It's hanging with no error, after a couple of dozen pages. Seems to happen even after restoring the DB locally and trying with a clean MW install. Not sure what's going on. :-(

Sep 11 2018, 01:03 · MediaWiki, Import

Sep 10 2018

Samwilson added a comment to T3576: Migrate Wikimedia Australia wikis to Miraheze.

The uncompressed images directories are:

  • 427M images_commwiki
  • 849M images_wmauwiki
Sep 10 2018, 07:30 · MediaWiki, Import
Samwilson added a comment to T3576: Migrate Wikimedia Australia wikis to Miraheze.

No, it's okay, we can supply XML dumps no worries. And will upload tarballs of the two images directories to Google Drive and send you a link.

Sep 10 2018, 02:12 · MediaWiki, Import

Sep 9 2018

Samwilson triaged T3578: Missing messages for Special:ManageWikiDefaultPermissions as Low priority.
Sep 9 2018, 09:24 · ManageWiki
Samwilson triaged T3576: Migrate Wikimedia Australia wikis to Miraheze as Normal priority.
Sep 9 2018, 04:02 · MediaWiki, Import
Samwilson added a comment to T3495: Please enable Extension:Purge and Extension:SacredText on both of my wikis please.

I don't think SacredText is a goer, because the source location for its data http://sacredtext.googlecode.com/svn/trunk/data is dead.

Sep 9 2018, 02:15 · Extensions
Samwilson added a comment to T3495: Please enable Extension:Purge and Extension:SacredText on both of my wikis please.

Purge is a very simple extension, and is running on quite a few websites. I've worked on it a couple of times and I think it'd be suitable to install for Miraheze. The only thing I'd note though is that there seems to a possibility that it's not actually required: in https://phabricator.wikimedia.org/T200054 Yaron suggests that it's possible to have the purge-without-confirmation without using the JS POST trick that the Purge extension has. I'm still trying to figure out what's going on there though. (Oh, of course, it might just be for the convenient 'purge' link that you want it, so that should be fine.)

Sep 9 2018, 02:08 · Extensions

Jul 29 2018

Samwilson added a comment to T3412: Please enable Extension:CodeMirror on both of my wikis please.

The only thing I'd note about CodeMirror is that there are a few bugs with it, that pop up in various circumstances. Basically, they're all hard ones to fix! There is rumour, however, of an upstream rewrite of the CodeMirror library, and that should help. No timeline for when it'll make it into the MediaWiki extension though.

Jul 29 2018, 06:26 · MacFan4000, Extensions, Configuration

Jul 15 2018

Samwilson added a comment to T3347: ScratchBlocks Extension.

Oh, and the executable bit is set for some reason on run_scratchblocks.js. Shouldn't be.

Jul 15 2018, 12:46 · Extensions
Samwilson added a comment to T3347: ScratchBlocks Extension.

This extension is a wrapper for a Javascript-based code formatting library. It doesn't do anything PHP-side other than load the required JS and render the parser tags, so I think that's all safe enough (tiny improvements? e.g. htmlspecialchars() is used directly, in stead of e.g. Sanitizer::escapeHtmlAllowEntities()). The javascript library is a submodule, and is pretty far out of date, so that could be updated. I've not delved into the details of that though, so if there's no missing functionality then perhaps all is fine.

Jul 15 2018, 12:44 · Extensions

Jul 12 2018

Samwilson added a comment to T3037: Request Extension:LinkTarget.

@Reception123 ah, cool! :) I've been trying to find time to get things running locally... maybe then I'll be able to help more.

Jul 12 2018, 09:59 · MediaWiki, MacFan4000
Samwilson added a comment to T3037: Request Extension:LinkTarget.

I'm not sure, but I think you can change $wgLinkTargetParentClasses via Special:ManageWiki? (I'm only just learning how things work though, so I might be wrong.)

Jul 12 2018, 09:56 · MediaWiki, MacFan4000

Jul 10 2018

Samwilson added a comment to T3037: Request Extension:LinkTarget.

Have a read of the examples.

Jul 10 2018, 22:51 · MediaWiki, MacFan4000
Samwilson added a comment to T3337: Add an osmf-mediawiki skin to my wiki.

It sounds like they may not be all that keen on other people using the skin. Not that that means it can't be used, given that it is open-licensed, but it would probably mean someone else would need to do the work to prepare it for use here. Any, I'd recommend against using it if the OSMF doesn't want it to be used.

Jul 10 2018, 22:46 · MediaWiki (SRE), Universal Omega, Extensions, Extension-Review
Samwilson added a comment to T3337: Add an osmf-mediawiki skin to my wiki.

@Eduaddad yep, that's what it should do, but at the moment the skin is including its own logo.

Jul 10 2018, 03:12 · MediaWiki (SRE), Universal Omega, Extensions, Extension-Review
Samwilson added a comment to T3337: Add an osmf-mediawiki skin to my wiki.

That skin currently hardcodes the OSM Foundation logo:

Jul 10 2018, 02:58 · MediaWiki (SRE), Universal Omega, Extensions, Extension-Review

May 15 2018

Samwilson added a comment to T2705: Install Pivot skin.

Looks like a good skin from an experienced developer. I can't see anything wrong with it in my reading. There are some external resource requests (addthis.com), but they're all off by default. There are some open issues, but none security-related.

May 15 2018, 00:41 · Extensions

May 4 2018

Samwilson placed T1832: Review skin: Liberty up for grabs.
May 4 2018, 01:10 · revi, MacFan4000, Extensions
Samwilson added a comment to T2640: Install extension ImportArticles on tmewiki.

Looking at this again, I think it's a decline. This doesn't do anything useful, and doesn't work at all in a bunch of situations (e.g. different $wgScriptPath). It also doesn't use standard MediaWiki ways of doing things.

May 4 2018, 01:08 · MediaWiki, Import, Extension-Review

Apr 13 2018

Samwilson added a comment to T1832: Review skin: Liberty.

Oops, I should have read that! :) Thanks.

Apr 13 2018, 08:04 · revi, MacFan4000, Extensions

Apr 12 2018

Samwilson added a comment to T1832: Review skin: Liberty.

I'm getting a couple of errors (with latest master of Liberty):

Apr 12 2018, 23:45 · revi, MacFan4000, Extensions

Jan 21 2018

Samwilson added a comment to T2640: Install extension ImportArticles on tmewiki.

The point of this extension is to dynamically load JS and CSS from multiple wiki pages at once isn't it? And inject them into the page with <script> and <style> elements.

Jan 21 2018, 23:26 · MediaWiki, Import, Extension-Review

Dec 20 2017

Samwilson added a comment to T1459: Review PagesVisited.

Could https://www.mediawiki.org/wiki/Extension:JSBreadCrumbs be a possibility for this feature?

Dec 20 2017, 02:19 · Extensions

Dec 6 2017

Samwilson added a comment to T2448: Review CleanChanges.

This extension looks good to me. Can't see anything other than a few stylistic issues, certainly nothing around database access or security jumps out. CleanChanges is installed on https://translatewiki.net/wiki/Special:Version which I think is a good indication of maturity.

Dec 6 2017, 23:20 · Extensions

Nov 26 2017

Samwilson added a comment to T2464: Extension for shortwikiwiki(https://shortwiki.miraheze.org).

@Reception123 ah, that's true. :)

Nov 26 2017, 09:18 · Extensions, Extension-Review, MacFan4000, Configuration
Samwilson added a comment to T2464: Extension for shortwikiwiki(https://shortwiki.miraheze.org).

#Quiz is fine isn't it?

Nov 26 2017, 09:07 · Extensions, Extension-Review, MacFan4000, Configuration

Nov 9 2017

Samwilson added a comment to T2385: Enable extensions on unionnorteamericana.miraheze.org.

It's a simple extension, so could be quickly improved, but I wouldn't touch it as it stands.

Nov 9 2017, 22:52 · MacFan4000, Extensions, Configuration

Nov 4 2017

Samwilson added a comment to T2385: Enable extensions on unionnorteamericana.miraheze.org.

FlickrAPI is good to go once this patch is merged: https://gerrit.wikimedia.org/r/#/c/384642/ (I've forked the 3rd party library that it uses, and fixed a few bugs in it; I have plans to add new features to FlickrAPI).

Nov 4 2017, 23:54 · MacFan4000, Extensions, Configuration
Samwilson added a comment to T2378: activate extension:.

On the topic of MsUpload, I'd just add that there are some outstanding issues with it, but I reckon it's a great extension and that we (whoever use it) should continue to make it even better. (So, if anyone has any other unrecorded issues with it, please do report them!)

Nov 4 2017, 00:11 · MacFan4000, Configuration

Oct 30 2017

Samwilson added a comment to T1832: Review skin: Liberty.

I've tested that patch, and it looks good to me. I commented over there.

Oct 30 2017, 07:43 · revi, MacFan4000, Extensions
Samwilson added a comment to T1832: Review skin: Liberty.

Oh cool!

Oct 30 2017, 02:27 · revi, MacFan4000, Extensions

Oct 29 2017

Samwilson added a comment to T1832: Review skin: Liberty.

The first problem I see with this skin is that there are lots of untranslated strings in it, even for things (e.g. 'recentchanges') that have translations in core. These would probably be pretty easy to fix; I might try to find time, but it might be quicker for a Korean speaker. :-)

Oct 29 2017, 23:03 · revi, MacFan4000, Extensions
Herald added a project to T891: Review RandomFeaturedUser: MacFan4000.

I've created https://phabricator.wikimedia.org/T179245 with relation to this.

Oct 29 2017, 10:14 · MacFan4000, Extensions
Samwilson added a comment to T2352: Security review problem.

@CnocBride I think reaching out for specific things would be a great thing to do. Perhaps not a blanket call, though, but more "here's a thing we want to use, is it good to go?" might elicit more discussion.

Oct 29 2017, 09:45 · MacFan4000, Site Reliability Engineering
Samwilson added a comment to T2352: Security review problem.

@Reception123 I can try to help! Is it just a matter of looking at anything in Extension-Review and saying yea or nea to each extension? And, I guess, for any bad things found, raising bugs on the Wikimedia Phabricator?

Oct 29 2017, 09:39 · MacFan4000, Site Reliability Engineering

Oct 27 2017

Samwilson added a comment to T1906: Extension Graphviz.

But if you're a programmer, I'm sure you're aware of the wretched hive of scum and PHP that is the MW extension ecosystem. The WMF extensions are very good... the others, well...

Oct 27 2017, 01:43 · Extension-Review

Oct 20 2017

Samwilson added a comment to T1906: Extension Graphviz.

I work in the Community Tech team at the WMF, but I use GraphViz in my personal capacity on my own sites. I hope I'd answer yes to all of your questions. :-)

Oct 20 2017, 07:04 · Extension-Review
Samwilson added a comment to T1906: Extension Graphviz.

There's a patch in for GraphViz at the moment, to convert it to extension registration, if anyone would like to review it: https://gerrit.wikimedia.org/r/#/c/373735/

Oct 20 2017, 02:04 · Extension-Review