Page MenuHomeMiraheze

CreateWikiProject
ActivePublic

Members (5)

Watchers (4)

Details

Description

Project for issues affecting the CreateWiki extension.

Recent Activity

Mon, Jul 19

Universal_Omega closed T7577: New CreateWiki invalid database name error message is over escaped as Resolved.

Fixed with https://github.com/miraheze/CreateWiki/pull/228

Mon, Jul 19, 20:00 · MediaWiki (SRE), Universal Omega, CreateWiki

Sat, Jul 17

Void merged task T7338: Investigate cause of wiki being created but not creation farmer log entry being created into T7626: redis-server is occasionally killed for OOM.
Sat, Jul 17, 01:05 · CreateWiki, Universal Omega, MediaWiki (SRE)

Thu, Jul 15

Universal_Omega added a comment to T7577: New CreateWiki invalid database name error message is over escaped.

Can you please tell me what actions led up to receiving this error?

Thu, Jul 15, 23:03 · MediaWiki (SRE), Universal Omega, CreateWiki

Mon, Jul 12

Reception123 added a comment to T7338: Investigate cause of wiki being created but not creation farmer log entry being created.

Error with https://meta.miraheze.org/wiki/Special:RequestWikiQueue/19224

Mon, Jul 12, 06:06 · CreateWiki, Universal Omega, MediaWiki (SRE)

Sun, Jul 4

Universal_Omega added a comment to T7577: New CreateWiki invalid database name error message is over escaped.

Also,

htmlspecialchars( "The database name doesn't end in a valid suffix (e.g. 'wiki').", ENT_QUOTES, 'UTF-8', false );

works, which tells me it has nothing to do with wfMessage()->escaped() as that's basically exactly what Message::escaped() uses when you go back to the source. Also using wfMessage( 'createwiki-error-notsuffixed' )->escaped(); directly in eval.php seems to work as well. (returns the correct escaped output)

Sun, Jul 4, 01:55 · MediaWiki (SRE), Universal Omega, CreateWiki
Universal_Omega added a comment to T7577: New CreateWiki invalid database name error message is over escaped.

As far as I see this had nothing to do with the recent changes. The "notsuffixed" message wasn't even touched/used in change.

Sun, Jul 4, 00:04 · MediaWiki (SRE), Universal Omega, CreateWiki

Sat, Jul 3

RhinosF1 added a comment to T7338: Investigate cause of wiki being created but not creation farmer log entry being created.

I had Redis issues on an import last night

Sat, Jul 3, 17:06 · CreateWiki, Universal Omega, MediaWiki (SRE)
Dmehus added a comment to T7338: Investigate cause of wiki being created but not creation farmer log entry being created.

It's happened again in this wiki request. No farmer log creation log entry created, but the user's bureaucrat and sysop rights were added. Main Page was created, but still we have Exception experienced creating the wiki. Error is: Redis server error: socket error on read socket. I agree with @Void above that while the lack of a farmer log entry is relatively minor (we should be able to manually add these via the database as they occur), the fact that the CreateWiki job is not completing with full success is problematic. I suspect there's likely a communication problem or conflict of some sort between the way the CreateWiki extension/MediaWiki "talk" to the Redis server. Not sure what that problem is, but this should definitely be investigated thoroughly, tough as a nut to crack as it may be...

Sat, Jul 3, 15:35 · CreateWiki, Universal Omega, MediaWiki (SRE)

Fri, Jul 2

Universal_Omega added a comment to T7577: New CreateWiki invalid database name error message is over escaped.

I guess MWException escapes the message so there's no need to use ->escaped() on the return when building the message.

Fri, Jul 2, 00:03 · MediaWiki (SRE), Universal Omega, CreateWiki

Thu, Jul 1

RhinosF1 added a comment to T7577: New CreateWiki invalid database name error message is over escaped.

I guess MWException escapes the message so there's no need to use ->escaped() on the return when building the message.

Thu, Jul 1, 15:34 · MediaWiki (SRE), Universal Omega, CreateWiki
RhinosF1 renamed T7577: New CreateWiki invalid database name error message is over escaped from New CreateWiki invalid database name error message contains an error in the displayed output to New CreateWiki invalid database name error message is over escaped.
Thu, Jul 1, 15:29 · MediaWiki (SRE), Universal Omega, CreateWiki
Dmehus moved T7577: New CreateWiki invalid database name error message is over escaped from Backlog to Bugs on the CreateWiki board.
Thu, Jul 1, 15:29 · MediaWiki (SRE), Universal Omega, CreateWiki
Dmehus moved T7577: New CreateWiki invalid database name error message is over escaped from Backlog to Short Term on the MediaWiki (SRE) board.
Thu, Jul 1, 15:29 · MediaWiki (SRE), Universal Omega, CreateWiki
Dmehus moved T7577: New CreateWiki invalid database name error message is over escaped from Unsorted to Short Term on the Universal Omega board.
Thu, Jul 1, 15:28 · MediaWiki (SRE), Universal Omega, CreateWiki
Dmehus updated the task description for T7577: New CreateWiki invalid database name error message is over escaped.
Thu, Jul 1, 15:28 · MediaWiki (SRE), Universal Omega, CreateWiki
Dmehus triaged T7577: New CreateWiki invalid database name error message is over escaped as Normal priority.
Thu, Jul 1, 15:28 · MediaWiki (SRE), Universal Omega, CreateWiki

Jun 30 2021

Void changed the visibility for T7566: Editing wiki request allows for inserting uppercase characters into database name.
Jun 30 2021, 20:34 · Security, MediaWiki (SRE), CreateWiki, Universal Omega
Void closed T7566: Editing wiki request allows for inserting uppercase characters into database name as Resolved.

Merged fix, and modified the dbname of the affected request.

Jun 30 2021, 20:32 · Security, MediaWiki (SRE), CreateWiki, Universal Omega
Universal_Omega moved T7566: Editing wiki request allows for inserting uppercase characters into database name from Unsorted to Short Term on the Universal Omega board.
Jun 30 2021, 17:00 · Security, MediaWiki (SRE), CreateWiki, Universal Omega
Universal_Omega moved T7566: Editing wiki request allows for inserting uppercase characters into database name from Backlog to Short Term on the MediaWiki (SRE) board.
Jun 30 2021, 17:00 · Security, MediaWiki (SRE), CreateWiki, Universal Omega
Universal_Omega moved T7566: Editing wiki request allows for inserting uppercase characters into database name from Backlog to Bugs on the CreateWiki board.
Jun 30 2021, 17:00 · Security, MediaWiki (SRE), CreateWiki, Universal Omega
Universal_Omega added a comment to T7566: Editing wiki request allows for inserting uppercase characters into database name.

This is not really a security issue. There is validation upon attempting to create the wiki that will fail if validation fails.

Jun 30 2021, 16:45 · Security, MediaWiki (SRE), CreateWiki, Universal Omega
Owen added a comment to T7566: Editing wiki request allows for inserting uppercase characters into database name.
In T7566#152061, @Owen wrote:

https://github.com/miraheze/CreateWiki/blob/master/includes/WikiManager.php#L253 - has a check in place for technical limitations it seems.

Blacklist domains aren’t included above but that makes sense as they would be blacklisted against common user requests.

I’m recording here that I do not believe this is a security issue.

The check for an initial submit is done https://github.com/miraheze/CreateWiki/blob/master/includes/RequestWiki/SpecialRequestWiki.php#L121 but when editing the form that check isn't happening.

Jun 30 2021, 15:55 · Security, MediaWiki (SRE), CreateWiki, Universal Omega
RhinosF1 added a comment to T7566: Editing wiki request allows for inserting uppercase characters into database name.
In T7566#152061, @Owen wrote:

https://github.com/miraheze/CreateWiki/blob/master/includes/WikiManager.php#L253 - has a check in place for technical limitations it seems.

Blacklist domains aren’t included above but that makes sense as they would be blacklisted against common user requests.

I’m recording here that I do not believe this is a security issue.

The check for an initial submit is done https://github.com/miraheze/CreateWiki/blob/master/includes/RequestWiki/SpecialRequestWiki.php#L121 but when editing the form that check isn't happening.

Jun 30 2021, 15:55 · Security, MediaWiki (SRE), CreateWiki, Universal Omega
Owen added a comment to T7566: Editing wiki request allows for inserting uppercase characters into database name.

https://github.com/miraheze/CreateWiki/blob/master/includes/WikiManager.php#L253 - has a check in place for technical limitations it seems.

Jun 30 2021, 15:52 · Security, MediaWiki (SRE), CreateWiki, Universal Omega
RhinosF1 added a comment to T7566: Editing wiki request allows for inserting uppercase characters into database name.

Void has also raised blacklisted subdomains etc

Jun 30 2021, 15:44 · Security, MediaWiki (SRE), CreateWiki, Universal Omega
Void claimed T7566: Editing wiki request allows for inserting uppercase characters into database name.
Jun 30 2021, 15:05 · Security, MediaWiki (SRE), CreateWiki, Universal Omega
RhinosF1 added a comment to T7566: Editing wiki request allows for inserting uppercase characters into database name.

See https://github.com/miraheze/CreateWiki-ghsa-3p5g-25fw-r6p3 & https://github.com/miraheze/CreateWiki/security/advisories/GHSA-3p5g-25fw-r6p3 for patches if you have any

Jun 30 2021, 14:58 · Security, MediaWiki (SRE), CreateWiki, Universal Omega
RhinosF1 added a comment to T7566: Editing wiki request allows for inserting uppercase characters into database name.

Void has also raised blacklisted subdomains etc

Jun 30 2021, 14:54 · Security, MediaWiki (SRE), CreateWiki, Universal Omega
RhinosF1 added a project to T7566: Editing wiki request allows for inserting uppercase characters into database name: Security.
Jun 30 2021, 14:53 · Security, MediaWiki (SRE), CreateWiki, Universal Omega
RhinosF1 updated subscribers of T7566: Editing wiki request allows for inserting uppercase characters into database name.
Jun 30 2021, 14:52 · Security, MediaWiki (SRE), CreateWiki, Universal Omega
RhinosF1 added a comment to T7566: Editing wiki request allows for inserting uppercase characters into database name.

By definition this is a security issue. We've got missing validation with the ability to take the site partially down.

Jun 30 2021, 14:52 · Security, MediaWiki (SRE), CreateWiki, Universal Omega
RhinosF1 changed the visibility for T7566: Editing wiki request allows for inserting uppercase characters into database name.
Jun 30 2021, 14:51 · Security, MediaWiki (SRE), CreateWiki, Universal Omega
Void added a comment to T7566: Editing wiki request allows for inserting uppercase characters into database name.
In T7566#152019, @Void wrote:

Bug is caused by a wiki request having been edited to have a database name of Musicwiki, which matches against musicwiki, but the former does not actually exist, which is what is causing this error.

Should we not require lowercase for DB names?

Jun 30 2021, 14:50 · Security, MediaWiki (SRE), CreateWiki, Universal Omega
Void renamed T7566: Editing wiki request allows for inserting uppercase characters into database name from Persistent cannot connect to database server (db11.miraheze.org) on metawiki to Editing wiki request allows for inserting uppercase characters into database name.
Jun 30 2021, 14:49 · Security, MediaWiki (SRE), CreateWiki, Universal Omega

Jun 28 2021

Dmehus added a comment to T7338: Investigate cause of wiki being created but not creation farmer log entry being created.
In T7338#150494, @Void wrote:

IMO this task is still valid, but not for the focus it has. I don't particularly care about the wiki creator statistics being accurate. But I do care about the implication that a failure in the wiki creation process leaves the wiki in an incomplete status. IMO the proper solution here is to have a wiki creation failure clear the incomplete wiki and report the issue somehow.

Jun 28 2021, 02:54 · CreateWiki, Universal Omega, MediaWiki (SRE)

Jun 20 2021

Void added a comment to T7338: Investigate cause of wiki being created but not creation farmer log entry being created.

IMO this task is still valid, but not for the focus it has. I don't particularly care about the wiki creator statistics being accurate. But I do care about the implication that a failure in the wiki creation process leaves the wiki in an incomplete status. IMO the proper solution here is to have a wiki creation failure clear the incomplete wiki and report the issue somehow.

Jun 20 2021, 18:17 · CreateWiki, Universal Omega, MediaWiki (SRE)
Dmehus reopened T7338: Investigate cause of wiki being created but not creation farmer log entry being created as "Open".
Jun 20 2021, 17:51 · CreateWiki, Universal Omega, MediaWiki (SRE)
Dmehus added a comment to T7338: Investigate cause of wiki being created but not creation farmer log entry being created.

Reopening per private dialogue with Reception123 on IRC. Please leave this for him to close. Thanks!

Jun 20 2021, 17:51 · CreateWiki, Universal Omega, MediaWiki (SRE)
RhinosF1 closed T7338: Investigate cause of wiki being created but not creation farmer log entry being created as Declined.

As Reception said, if it didn't create successfully then it won't log.

Jun 20 2021, 17:50 · CreateWiki, Universal Omega, MediaWiki (SRE)
Dmehus lowered the priority of T7338: Investigate cause of wiki being created but not creation farmer log entry being created from Normal to Low.

Per this

Jun 20 2021, 17:48 · CreateWiki, Universal Omega, MediaWiki (SRE)
Dmehus reopened T7338: Investigate cause of wiki being created but not creation farmer log entry being created as "Open".

@Reception123, this is reproducable as it has happened multiple times now. I suspect it's something to do with the way in which the updated CreateWiki extension "talks" to the now locally forked jobrunner/redis server process. As you told me privately this would definitely be looked into with a view to resolving, if you have no objections, I'd rather prefer to reopen this task, and lower its priority to low as it's a bit niche. I get that you're trying to reduce the task backlog, but as this is happening with increasing frequency and since the wiki creator statistics are based on created wiki farmer log entries, it does need to be resolved as it never happened before (i.e., late last year).

Jun 20 2021, 17:47 · CreateWiki, Universal Omega, MediaWiki (SRE)
Reception123 closed T7338: Investigate cause of wiki being created but not creation farmer log entry being created as Declined.

The reason why the log wasn't created was because something went wrong with the particular wiki creation, and the log entry is the last thing that's executed. Unfortunately, we can't reproduce that error or investigate it really especially since a month has passed. CreateWiki errors can happen for all kinds of reasons but they are very rare in nature but are bound to happen every once in a while because of different factors. For that reason this task should be declined as there is nothing that can be realistically done to investigate that particular issue (which isn't the log not creating in itself)

Jun 20 2021, 16:50 · CreateWiki, Universal Omega, MediaWiki (SRE)

Jun 15 2021

Sario528 removed a watcher for CreateWiki: Sario528.
Jun 15 2021, 17:17

Jun 12 2021

Bukkit added a member for CreateWiki: Bukkit.
Jun 12 2021, 22:35

May 27 2021

John added a comment to T7373: Investigate cause of redis server error (socket error on read socket) when CreateWiki Extension creates a wiki.

Redis-JobRunner is additional software. It’s like saying MediaWiki is the cause of Matomo’s SSL certificate failing just because they have the same certificate - they’re entirely unrelated but confirmation bias suggests there’s a link because it’s easier to explain than an unknown cause.

May 27 2021, 06:21 · Universal Omega, MediaWiki (SRE), MediaWiki
RhinosF1 added a comment to T7373: Investigate cause of redis server error (socket error on read socket) when CreateWiki Extension creates a wiki.

Actually this may be a different error. I remember it first happened when John did work to Redis-JobRunner, so this must be a different error I guess.

Note: On this occasion, we got an actual error in the description whereas T7338 was a silent fail.

May 27 2021, 05:57 · Universal Omega, MediaWiki (SRE), MediaWiki
Dmehus added a comment to T7373: Investigate cause of redis server error (socket error on read socket) when CreateWiki Extension creates a wiki.

Actually this may be a different error. I remember it first happened when John did work to Redis-JobRunner, so this must be a different error I guess.

May 27 2021, 05:17 · Universal Omega, MediaWiki (SRE), MediaWiki
Dmehus moved T7373: Investigate cause of redis server error (socket error on read socket) when CreateWiki Extension creates a wiki from Backlog to Bugs on the CreateWiki board.
May 27 2021, 05:15 · Universal Omega, MediaWiki (SRE), MediaWiki
Dmehus moved T7373: Investigate cause of redis server error (socket error on read socket) when CreateWiki Extension creates a wiki from Unsorted to Short Term on the Universal Omega board.
May 27 2021, 05:15 · Universal Omega, MediaWiki (SRE), MediaWiki