https://gerrit.wikimedia.org/r/c/translatewiki/+/719181

Just to note, while it's not a huge deal for GlobalNewFiles since it requires CreateWiki, which is not much used externally, Phan did catch an error which would've caused the updater to fatal.

• T7942: [ManageWiki] Create better CI for MediaWiki standards and security
• T7943: [CreateWiki] Create better CI for MediaWiki standards and security
• T7944: [MatomoAnalytics] Create better CI for MediaWiki standards and security
• T7945: [GlobalNewFiles] Create better CI for MediaWiki standards and security
• T7946: [RemovePII] Create better CI for MediaWiki standards and security
• T7947: [DataDump] Create better CI for MediaWiki standards and security
• T7948: [RottenLinks] Create better CI for MediaWiki standards and security
• T7949: [IncidentReporting] Create better CI for MediaWiki standards and security
• T7950: [WikiDiscover] Create better CI for MediaWiki standards and security

In T7939#160072, @John wrote:

In T7939#160067, @RhinosF1 wrote:

In T7939#160062, @John wrote:

One task - one end objective is a standard purpose. Why do we have a task for 9 separate objectives?

It's one end objective that all Miraheze maintained extensions have mediawiki-standard CI

9 different software components = 9 different tasks surely? They just good task management and makes things easily trackable and measurable.

It's probably better to be tracking things separately and have subtasks for each extension

In T7939#160067, @RhinosF1 wrote:

In T7939#160062, @John wrote:

One task - one end objective is a standard purpose. Why do we have a task for 9 separate objectives?

It's one end objective that all Miraheze maintained extensions have mediawiki-standard CI

In T7939#160062, @John wrote:

One task - one end objective is a standard purpose. Why do we have a task for 9 separate objectives?

It's one end objective that all Miraheze maintained extensions have mediawiki-standard CI

One task - one end objective is a standard purpose. Why do we have a task for 9 separate objectives?

I've extended the above mentioned PR to now also include phan.

https://github.com/miraheze/ManageWiki/pull/297 does this for ManageWiki, implementing eslint, stylelint, and phpcs. It also will make GitHub Actions automatically commit formatting fixes, when possible.

GitHub has issued CVE-2021-39186 for this Security Advisory after reviewing reviewing it for compliance with CVE rules. Once you've published your Security Advisory, we'll publish the CVE to the CVE List.

Thank you for making the open source ecosystem more secure by fixing and responsibly disclosing this vulnerability.

https://github.com/miraheze/GlobalNewFiles-ghsa-57p5-hqjq-h7vg/pull/1/files

@Majavah: there should be an option above to create a private patch, please feel free to ^

https://github.com/miraheze/GlobalNewFiles/security/advisories/GHSA-57p5-hqjq-h7vg

Thank you for reporting this.